Bug 529563 (TreeIconRedrawIssue) - [GTK3][Tree][Drawing] Tree does not repaint upon request
Summary: [GTK3][Tree][Drawing] Tree does not repaint upon request
Status: CLOSED DUPLICATE of bug 511133
Alias: TreeIconRedrawIssue
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard: hasSnippet
Keywords: triaged
: 493513 (view as bug list)
Depends on:
Blocks: 531051 527444
  Show dependency tree
 
Reported: 2018-01-09 04:03 EST by Thomas Singer CLA
Modified: 2018-02-22 10:01 EST (History)
3 users (show)

See Also:


Attachments
Sample code to reproduce (3.03 KB, text/plain)
2018-01-09 04:04 EST, Thomas Singer CLA
no flags Details
Screencast on Windows 10 (68.83 KB, image/gif)
2018-01-09 04:05 EST, Thomas Singer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Singer CLA 2018-01-09 04:03:42 EST
Please run attached snippet. It should show a spinning progress image before the first tree item, starting/stopping after a few seconds. On Windows 10 this works fine, but on Linux no repaint events occur and hence no progress is visible - unless you move the mouse over the tree control.
Comment 1 Thomas Singer CLA 2018-01-09 04:04:28 EST
Created attachment 272183 [details]
Sample code to reproduce
Comment 2 Thomas Singer CLA 2018-01-09 04:05:20 EST
Created attachment 272184 [details]
Screencast on Windows 10
Comment 3 Leo Ufimtsev CLA 2018-02-12 09:37:15 EST
Reproduced on Gtk3.22 / Fedora 27.
Doesn't reproduce on Gtk2. I.e, when selected, icon spins.

@Eric, btw, issue still occurs with me having checked out the revert:
https://git.eclipse.org/r/#/c/116980/
Comment 4 Eric Williams CLA 2018-02-12 09:58:55 EST
(In reply to Leo Ufimtsev from comment #3)
> Reproduced on Gtk3.22 / Fedora 27.
> Doesn't reproduce on Gtk2. I.e, when selected, icon spins.
> 
> @Eric, btw, issue still occurs with me having checked out the revert:
> https://git.eclipse.org/r/#/c/116980/

I don't think that is relevant, it's most likely a separate issue. 

Thanks for the bug report and snippet Thomas.
Comment 5 Eric Williams CLA 2018-02-14 09:39:31 EST
(In reply to Leo Ufimtsev from comment #3)
> @Eric, btw, issue still occurs with me having checked out the revert:
> https://git.eclipse.org/r/#/c/116980/

This revert was only for Table, the widget in question with Thomas' snippet is a Tree widget. After the fix for bug 511133, I cannot reproduce this issue.

Thomas can you try with SWT master (or use tomorrow's I-build)? I believe this bug is fixed but I'll wait until you confirm.
Comment 6 Eric Williams CLA 2018-02-14 12:23:38 EST
*** Bug 493513 has been marked as a duplicate of this bug. ***
Comment 7 Leo Ufimtsev CLA 2018-02-15 17:27:15 EST
Seems like this was fixed by Eric's tree icon patch a few days ago:
https://git.eclipse.org/r/#/c/117300/

@Thomas Singer, can you verify against tomorrow's build? (15th & onwards).

Like maybe download the SWT.jar or checkout latest swt master.
http://download.eclipse.org/eclipse/downloads
Comment 8 Thomas Singer CLA 2018-02-16 11:22:45 EST
Eric and Leo, yes, the latest master build fixes the problem.
Comment 9 Eric Williams CLA 2018-02-16 11:24:14 EST
(In reply to Thomas Singer from comment #8)
> Eric and Leo, yes, the latest master build fixes the problem.

Marking as duplicate.

*** This bug has been marked as a duplicate of bug 511133 ***
Comment 10 Thomas Singer CLA 2018-02-22 07:56:02 EST
Are you sure this bug is related to missing images (bug 511133)?

Would it be possible to backport the fix to the R4_7_maintenance branch or will GTK3-fixed require 4.8/master?
Comment 11 Eric Williams CLA 2018-02-22 10:01:40 EST
(In reply to Thomas Singer from comment #10)
> Are you sure this bug is related to missing images (bug 511133)?
> 
> Would it be possible to backport the fix to the R4_7_maintenance branch or
> will GTK3-fixed require 4.8/master?

Yes, the fix for that bug was pretty major in the sense that it affected the way Trees/Tables are drawn. This is why it fixes this bug.

As for backporting, we are in RC3 now for the last service release of Oxygen, so no. I would also prefer to let it sit in 4.8/master for now so we can catch any serious regressions if they pop up.