Bug 529368 - [GTK2] icons for SWT.ICON_SEARCH SWT.ICON_CANCEL not displayed properly
Summary: [GTK2] icons for SWT.ICON_SEARCH SWT.ICON_CANCEL not displayed properly
Status: CLOSED DUPLICATE of bug 530841
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.7   Edit
Hardware: Other Linux
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, triaged
Depends on:
Blocks: 530841
  Show dependency tree
 
Reported: 2018-01-03 07:38 EST by py e4 CLA
Modified: 2018-07-12 10:11 EDT (History)
3 users (show)

See Also:

Attachments
sample screen copy (1.92 KB, image/png)
2018-01-03 07:38 EST, py e4 CLA 		no flags Details
icons with gtk3 (5.45 KB, image/png)
2018-01-03 11:10 EST, py e4 CLA 		no flags Details
icons with Neon (2.43 KB, image/png)
2018-01-03 11:16 EST, py e4 CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description py e4 CLA 2018-01-03 07:38:42 EST 
Created attachment 272100 [details]
sample screen copy

with this code:  w = new Text(parent, SWT.SEARCH | SWT.ICON_SEARCH | SWT.ICON_CANCEL);
icons are not displayed properly.


(displayed ok with 4.6 neon)
Comment 1 Andrey Loskutov CLA 2018-01-03 09:36:11 EST 
Which GTK theme are you using, and which icon set? Are you on 32 bit Linux?
Comment 2 py e4 CLA 2018-01-03 10:52:44 EST 
org.eclipse.swt.internal.gtk.theme=Glider
org.eclipse.swt.internal.gtk.version=2.24.23

org.eclipse.e4.ui.swt.gtk (1.0.200.v20170513-0428) "Eclipse UI GTK Enhancements" [Resolved]
org.eclipse.equinox.launcher.gtk.linux.x86_64 (1.1.551.v20171108-1834) "Equinox Launcher Linux X86_64 Fragment" [Resolved]
org.eclipse.swt.gtk.linux.x86_64 (3.106.2.v20171129-0543) "Standard Widget Toolkit for GTK" [Resolved]


(not sure about icon set)
Comment 3 Eric Williams CLA 2018-01-03 10:54:23 EST 
(In reply to py e4 from comment #2)
> org.eclipse.swt.internal.gtk.theme=Glider
> org.eclipse.swt.internal.gtk.version=2.24.23
> 
> org.eclipse.e4.ui.swt.gtk (1.0.200.v20170513-0428) "Eclipse UI GTK
> Enhancements" [Resolved]
> org.eclipse.equinox.launcher.gtk.linux.x86_64 (1.1.551.v20171108-1834)
> "Equinox Launcher Linux X86_64 Fragment" [Resolved]
> org.eclipse.swt.gtk.linux.x86_64 (3.106.2.v20171129-0543) "Standard Widget
> Toolkit for GTK" [Resolved]
> 
> 
> (not sure about icon set)

Does this bug only happen on GTK2? What about GTK3?
Comment 4 py e4 CLA 2018-01-03 11:10:09 EST 
Created attachment 272109 [details]
icons with gtk3

gtk3 seems ok. see attached screencopy.
Comment 5 py e4 CLA 2018-01-03 11:16:06 EST 
Created attachment 272110 [details]
icons with Neon

for reference, the icons with 4.6 neon.
Comment 6 Eric Williams CLA 2018-01-03 11:23:23 EST 
(In reply to py e4 from comment #4)
> Created attachment 272109 [details]
> icons with gtk3
> 
> gtk3 seems ok. see attached screencopy.

It's possible that this bug was caused by a fix for bug 517508 (but I am not sure).

GTK2 only bugs are low priority at the moment as manpower is limited -- however we are happy to accept patches to fix these sorts of issues.

If this is a critical issue for you I would recommend using SWT with GTK3, as this is where the majority of the development is happening at this time.
Comment 7 Leo Ufimtsev CLA 2018-02-07 10:34:35 EST 
Triaging Gtk2-only bugs. Please see Bug 530841 for details.
If this bug is not gtk2-specific, please indicate.
Thank you for your bug submission.
Comment 8 Alexander Kurtakov CLA 2018-03-23 09:38:22 EDT 
Any reason you run with GTK2 still? Esp as GTK3 is known to be in way better shape than GTK2 now.
Comment 9 py e4 CLA 2018-03-26 06:20:45 EDT 
(In reply to Alexander Kurtakov from comment #8)
> Any reason you run with GTK2 still? 

legacy and delay in rollout.
(we can stick to neon if not fixed in oxygen ;)
Comment 10 Alexander Kurtakov CLA 2018-03-26 06:30:35 EDT 
(In reply to py e4 from comment #9)
> (In reply to Alexander Kurtakov from comment #8)
> > Any reason you run with GTK2 still? 
> 
> legacy and delay in rollout.
> (we can stick to neon if not fixed in oxygen ;)

Oxygen.3 is already done so no further swt changes in Oxygen either. I strongly recommend urging the move to GTK3 as GTK2 is to be phased out .
Comment 11 Eric Williams CLA 2018-07-10 13:57:51 EDT 
Please note: GTK2 support for SWT is being dropped in Eclipse 4.10 / SimRel 2018-12 release. 

See the following mail for more info: http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg15783.html
Comment 12 Alexander Kurtakov CLA 2018-07-12 10:11:22 EDT 
Marking the bug as duplicate of the GTK2 tracker as no work for GTK2 issues will happen. Please reopen if you still face the issue using GTK 3.x.

*** This bug has been marked as a duplicate of bug 530841 ***