Bug 529248 - "New console" should be on top, and other consoles order fixed
Summary: "New console" should be on top, and other consoles order fixed
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.8.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-27 11:48 EST by Andrey Loskutov CLA
Modified: 2018-01-22 04:27 EST (History)
1 user (show)

See Also:


Attachments
Fixed console contributions (8.33 KB, image/png)
2017-12-27 12:15 EST, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2017-12-27 11:48:25 EST
Triggered by bug 528957 comment 5 I found some (very old) issues with current console contributions menu. See screenshots at attachment 272042 [details] and at attachment 272041 [details].

1) "New Console" is semantically totally different from all other contributions to the menu: it does NOT create a new page inside the console, it creates a new console instance! However the menu is currently neither separated from other contributions nor properly located, and also has no icon.

=> we should move it always to front, separate from others and give it a "Console" icon.

2) All console contributions aren't sorted in any way, and due bug 528957 are related to the installation order of plugins. This is counter-intuitive. 

=> After 1) is fixed, the remaining consoles are all "equal" and should be placed in alphabetical order - to always have a consistent order and to simplify the visual search for the consoles.

I have patches for both points.
Comment 1 Eclipse Genie CLA 2017-12-27 12:11:23 EST
New Gerrit change created: https://git.eclipse.org/r/114768
Comment 2 Andrey Loskutov CLA 2017-12-27 12:15:41 EST
Created attachment 272047 [details]
Fixed console contributions

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/114768

The attached picture shows how the menu looks like after this patch. Note the "New Console" icon, position, separator below it and the sorted menus after.
Comment 4 Sarika Sinha CLA 2018-01-22 04:27:18 EST
Verified using
Eclipse SDK

Version: Photon (4.8)
Build id: I20180121-2000