Bug 528860 - Polish e4 Tools
Summary: Polish e4 Tools
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Christof Joswig CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on: 500898
Blocks:
  Show dependency tree
 
Reported: 2017-12-16 09:23 EST by Dani Megert CLA
Modified: 2018-10-09 10:05 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2017-12-16 09:23:10 EST 
The first time I got contact with e4 tools shows they are not at the platform quality:

Model Editor has no mnemonics.

Please make a pass over the tools and adjust them to platform quality or remove them again.
Comment 1 Dani Megert CLA 2017-12-16 09:24:39 EST 
(In reply to Dani Megert from comment #0)
> Model Editor has no mnemonics.

The preference page.
Comment 2 Dani Megert CLA 2017-12-18 10:08:39 EST 
(In reply to Dani Megert from comment #0)
> The first time I got contact with e4 tools shows they are not at the
> platform quality:
> 
> Model Editor has no mnemonics.
> 
> Please make a pass over the tools and adjust them to platform quality or
> remove them again.

Just to clarify for anyone who reads this: The e4 tools are not part of the RCP or Platform downloads. But they should still adhere to the quality of the Eclipse SDK.
Comment 3 Dani Megert CLA 2018-03-12 06:17:06 EDT 
Ping!
Comment 4 Lars Vogel CLA 2018-03-21 11:40:03 EDT 
Olivier, could you add mnemonics to the model editor preference page? Basically use & for the letters in the *.properties file.
Comment 5 Olivier Prouvost CLA 2018-03-21 12:37:13 EDT 
What and where are defined the platform quality rules ? Are they more rules than just mnemonics for pref page ? 

@Lars : WDYM by : Basically use & for the letters in the *.properties file. ?? 

Menomonics are used to filter the pref page in the preference dialog ? Right ?
Comment 6 Lars Vogel CLA 2018-03-21 12:39:35 EDT 
(In reply to Olivier Prouvost from comment #5)
> @Lars : WDYM by : Basically use & for the letters in the *.properties file.
> ?? 

Mnemonics are what you see if you hold the Alt key. If you for example write H&elp as text and long press the Alt key you can select the entry with Alt+e
Comment 7 Patrik Suzzi CLA 2018-03-21 19:59:29 EDT 
Mnemonics are not visible on Mac, but only on Linux and Windows.
Comment 8 Olivier Prouvost CLA 2018-03-22 08:50:34 EDT 
As I work on Mac, it would be better that Patrik takes the bug !  Patrick ? ;)
Comment 9 Dani Megert CLA 2018-05-10 10:19:56 EDT 
Patrik can you do this for RC1?
Comment 10 Dani Megert CLA 2018-05-17 10:14:39 EDT 
(In reply to Dani Megert from comment #9)
> Patrik can you do this for RC1?

Ping!
Comment 11 Lars Vogel CLA 2018-05-19 04:47:31 EDT 
(In reply to Dani Megert from comment #10)
> > Patrik can you do this for RC1?
> 
> Ping!

If Patrik is not able to take this, I can take it next Wednesday.
Comment 12 Dani Megert CLA 2018-05-24 09:16:19 EDT 
(In reply to Lars Vogel from comment #11)
> (In reply to Dani Megert from comment #10)
> > > Patrik can you do this for RC1?
> > 
> > Ping!
> 
> If Patrik is not able to take this, I can take it next Wednesday.

What did you mean with "next"?
Comment 13 Patrik Suzzi CLA 2018-08-15 05:31:33 EDT 
I'll start working on this today.
Comment 14 Lars Vogel CLA 2018-08-22 11:58:26 EDT 
(In reply to Patrik Suzzi from comment #13)
> I'll start working on this today.

Thanks Patrik, any update on the progress?
Comment 15 Lars Vogel CLA 2018-09-17 04:37:42 EDT 
Christof, as discussed, this might be something for you.
Comment 16 Christof Joswig CLA 2018-09-18 15:40:14 EDT 
ok I will fix the mnemonics, too.
Comment 17 Eclipse Genie CLA 2018-09-18 16:05:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/129659
Comment 19 Lars Vogel CLA 2018-09-19 04:33:35 EDT 
Thanks, Christof.
Comment 20 Dani Megert CLA 2018-10-09 09:23:06 EDT 
Can this be closed?