Bug 528258 - Builder's schedulingRule is resolved ignoring Command arguments
Summary: Builder's schedulingRule is resolved ignoring Command arguments
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-07 07:38 EST by Mickael Istria CLA
Modified: 2017-12-19 11:45 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-12-07 07:38:15 EST 
BuildManager.getRule() ignores the command arguments and only passes the general build arguments. That can easily cause issues in case the scheduling rule is conditionned by arguments. It also emphasizes that the BuildManager expects that multiple call to the same IncrementalBuilder.getRule(...) are expected to return the same rule, which is not requested by API.
Comment 1 Eclipse Genie CLA 2017-12-07 09:09:07 EST 
New Gerrit change created: https://git.eclipse.org/r/113006