528180 – [sonar] Resolve "Inefficient use of keySet iterator instead of entrySet iterator"

Bug 528180 - [sonar] Resolve "Inefficient use of keySet iterator instead of entrySet iterator"

Summary: [sonar] Resolve "Inefficient use of keySet iterator instead of entrySet itera...

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.8
Hardware:	PC Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	4.8 M5
Assignee:	Karsten Thoms
QA Contact:

URL:
Whiteboard:
Keywords:	bugday

Duplicates (2):	540283 541411 (view as bug list)
Depends on:	519991
Blocks:
	Show dependency tree

Reported:	2017-12-05 21:43 EST by Karsten Thoms
Modified:	2018-12-13 11:37 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Karsten Thoms

2017-12-05 21:43:01 EST

Resolve issues reported by this Sonar Query: https://sonar.eclipse.org/drilldown/issues/33316?&rule=findbugs%3AWMI_WRONG_MAP_ITERATOR&rule_sev=CRITICAL&severity=CRITICAL

Comment 1 Karsten Thoms

2017-12-22 07:48:09 EST

Some code locations have already been refactored with bug#519991

Comment 2 Eclipse Genie

2017-12-22 08:39:08 EST

New Gerrit change created: https://git.eclipse.org/r/114673

Comment 3 Eclipse Genie

2018-01-03 04:48:13 EST

New Gerrit change created: https://git.eclipse.org/r/114888

Comment 4 Eclipse Genie

2018-01-15 06:24:02 EST

New Gerrit change created: https://git.eclipse.org/r/115377

Comment 5 Eclipse Genie

2018-01-16 02:57:42 EST

Gerrit change https://git.eclipse.org/r/114673 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e6bcd2864383d01053a0172700bf4c44f2321c4f

Comment 6 Alexander Kurtakov

2018-01-16 02:59:46 EST

Thanks for the patch Karsten.

Comment 7 Karsten Thoms

2018-01-23 18:06:10 EST

Verified by code inspection. SonarQube job is not working for PDE at the moment.

Comment 8 Karsten Thoms

2018-10-18 16:45:10 EDT

*** Bug 540283 has been marked as a duplicate of this bug. ***

Comment 9 Julian Honnen

2018-12-13 11:37:17 EST

*** Bug 541411 has been marked as a duplicate of this bug. ***