Bug 519991 - [SonarLint] Iterate over the "entrySet" instead of the "keySet" in org.eclipse.pde.ui
Summary: [SonarLint] Iterate over the "entrySet" instead of the "keySet" in org.eclips...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M4   Edit
Assignee: Karsten Thoms CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks: 528180
  Show dependency tree
 
Reported: 2017-07-21 04:57 EDT by Lars Vogel CLA
Modified: 2017-12-22 07:48 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-07-21 04:57:37 EDT
If I run SonarLint for org.eclipse.pde.ui I see the following performance relevant errors:


Resource	Date	Description
BundleSourcePage.java	null	Iterate over the "entrySet" instead of the "keySet".
CommandDetails.java	null	Iterate over the "entrySet" instead of the "keySet".
CommandDetails.java	null	Iterate over the "entrySet" instead of the "keySet".
CommandList.java	null	Iterate over the "entrySet" instead of the "keySet".
PDECompilersConfigurationBlock.java	null	Iterate over the "entrySet" instead of the "keySet".
PluginImportOperation.java	null	Iterate over the "entrySet" instead of the "keySet".
PluginImportOperation.java	null	Iterate over the "entrySet" instead of the "keySet".
TagManager.java	null	Iterate over the "entrySet" instead of the "keySet".
XMLReconcilingStrategy.java	null	Iterate over the "entrySet" instead of the "keySet".

We should fix that.
Comment 1 Lars Vogel CLA 2017-11-08 13:48:23 EST
Karsten, something for you?
Comment 2 Eclipse Genie CLA 2017-11-08 15:14:56 EST
New Gerrit change created: https://git.eclipse.org/r/111257
Comment 4 Lars Vogel CLA 2017-11-08 15:50:20 EST
Thanks, Karsten.
Comment 5 Vikas Chandra CLA 2017-12-05 05:53:02 EST
Can you please verify this one?