Bug 528172 - [Generic Editor] Support all Text Editor mode toggles by default
Summary: [Generic Editor] Support all Text Editor mode toggles by default
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Carsten Reckord CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-12-05 12:49 EST by Carsten Reckord CLA
Modified: 2017-12-10 06:07 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Reckord CLA 2017-12-05 12:49:05 EST
The Generic Editor should  by default support the three mode toggles available for text editors:

- Toggle Word Wrap (org.eclipse.ui.edit.text.toggleWordWrap)
- Toggle Block Selection (org.eclipse.ui.edit.text.toggleBlockSelectionMode)
- Show Whitespace Characters (org.eclipse.ui.edit.text.toggleShowWhitespaceCharacters)

Currently, the toggle actions don't show up in the toolbar when a Generic Editor is active.

From a user perspective, it's very strange that these basic features are only available on some text editors, but not on others. It makes for a rather inconsistent UX. Generic Editor would be a great starting point to offer more consistency in this regards.
Comment 1 Carsten Reckord CLA 2017-12-05 13:09:34 EST
The necessary capabilities are all present in the Generic Editor, however the toolbar buttons are hidden by default.

This seems to be caused by the "Editor Presentation" action set being disabled for the Generic Editor. In comparison, the basic Text Editor and the Java Editor both have that action set enabled by default.

If I enable it manually via "Customize Perspective", the buttons show up as expected.
Comment 2 Eclipse Genie CLA 2017-12-06 00:01:18 EST
New Gerrit change created: https://git.eclipse.org/r/112903
Comment 4 Mickael Istria CLA 2017-12-10 06:07:36 EST
Thanks a lot Carsten for this report/patch, and Andrey for the review/merge.