Bug 526443 - open symbol in workspace dialog doesn't call the language server if query changes
Summary: open symbol in workspace dialog doesn't call the language server if query cha...
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LSP4E (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-25 04:35 EDT by Martin Lippert CLA
Modified: 2022-02-04 09:12 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lippert CLA 2017-10-25 04:35:29 EDT
If I open the "open symbol in workspace" dialog, it fetches results from the language server (that works fine). However, when I start typing a query string into the search box, the dialog seems to filter the content itself (which is fine), but before that it doesn't re-call the language server to fetch symbol information.

From my point of view, the client should call the language server again when the query changes, since the language server protocol allows the client to send a query string and therefore allows the server to deliver special symbols depending on the query.

VSCode does that and I think LSP4E should do the same.
Comment 1 Mickael Istria CLA 2021-11-16 15:55:12 EST
Eclipse LSP4E is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/lsp4e/issues/ instead. If this issue is relevant to you, your action is required.
0. Verify this issue is still happening with latest LSP4E snapshots (from https://download.eclipse.org/lsp4e/snapshots )
  if issue has disappeared, please change status of this issue to "CLOSED WORKFORME" with some details about your testing environment and how you did verify the issue; and you're done
  if issue is still present with snapshots:
* Create a new issue at https://github.com/eclipse/lsp4e/issues/
  ** Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  ** In the GitHub description, start with a link to this bugzilla ticket
  ** Optionally add new content to the description if it can helps towards resolution
  ** Submit GitHub issue
* Update bugzilla ticket
  ** Add to "See also" property (up right column) the link to the newly created GitHub issue
  ** Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  ** Set status as CLOSED MOVED
  ** Submit

All issues that remain open will be automatically closed soon. Then the Bugzilla component for LSP4E will be archived and made read-only.