Bug 525984 - Improve warning message "Not a valid list position."
Summary: Improve warning message "Not a valid list position."
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-10-13 05:20 EDT by Julian Hemm CLA
Modified: 2022-03-31 03:45 EDT (History)
7 users (show)

See Also:

Attachments
ModeUtil changes for improved warning message (787 bytes, patch)
2017-10-14 06:11 EDT, Julian Hemm CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Hemm CLA 2017-10-13 05:20:40 EDT 
If an invalid position (e.g. 0) is set as position in list in a fragment, the error message "Not a valid list position." is shown.

It would be helpful to have more context information and maybe a syntax description additionally

Could be something like
The position in list '%1' defined in '%2' is invalid. Valid positions are '%3'
Comment 1 Lars Vogel CLA 2017-10-13 05:56:50 EDT 
Good suggestion Julian, can you please provide a patch?
Comment 2 Julian Hemm CLA 2017-10-14 06:11:14 EDT 
Created attachment 271004 [details]
ModeUtil changes for improved warning message

added some context information to the error message.
Comment 3 Alexander Kurtakov CLA 2017-10-18 08:49:28 EDT 
(In reply to Julian Hemm from comment #2)
> Created attachment 271004 [details]
> ModeUtil changes for improved warning message
> 
> added some context information to the error message.

Would you please submit the patch via gerrit ? https://wiki.eclipse.org/Platform_UI/How_to_Contribute#Creating_a_Gerrit_review_or_a_patch
Comment 4 Lars Vogel CLA 2017-10-18 08:59:20 EDT 
(In reply to Alexander Kurtakov from comment #3)
> (In reply to Julian Hemm from comment #2)
> > Created attachment 271004 [details]
> > ModeUtil changes for improved warning message
> > 
> > added some context information to the error message.
> 
> Would you please submit the patch via gerrit ?
> https://wiki.eclipse.org/Platform_UI/
> How_to_Contribute#Creating_a_Gerrit_review_or_a_patch

Thanks Julian for the patch after our RCP training. Let me know via email (Lars.Vogel@vogella.com) if you need help with the Gerrit setup. It is actually relatively easy (takes less then a few minutes) but hard if you do it the first time.
Comment 5 Mickael Istria CLA 2017-11-29 12:06:27 EST 
Removing the Target Milestone. Please set it again to the right milestone when you can actually work on it.
Comment 6 Eclipse Genie CLA 2021-02-20 15:00:07 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/176567
Comment 7 Kalyan Prasad Tatavarthi CLA 2021-04-08 06:58:05 EDT 
Removing the Target Milestone. Please set it again to the right milestone when you plan to work on it.