Bug 525882 - Delete project dialog to also allow to delete "children" projects
Summary: Delete project dialog to also allow to delete "children" projects
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M4   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, noteworthy, usability
Depends on:
Blocks:
 
Reported: 2017-10-11 11:41 EDT by Mickael Istria CLA
Modified: 2018-05-04 08:41 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-10-11 11:41:13 EDT
The Delete Project dialog could provide an option to also delete "children project" (ie project under the same location).
Comment 1 Eclipse Genie CLA 2017-11-09 14:30:38 EST
New Gerrit change created: https://git.eclipse.org/r/111334
Comment 3 Mickael Istria CLA 2017-11-22 09:28:25 EST
If you don't mind I'd like to keep it open to add a note about it in the N&N. If we mark it resolved, I'll easily forget it.
Comment 4 Dani Megert CLA 2017-11-22 09:29:58 EST
(In reply to Mickael Istria from comment #3)
> If you don't mind I'd like to keep it open to add a note about it in the
> N&N.

Sure, np.
Comment 5 Mickael Istria CLA 2017-11-22 10:55:13 EST
N&N merged. Thanks everyone involved!
Comment 6 Dani Megert CLA 2017-11-23 05:41:45 EST
I found a major usability issue: When 'Delete project contents on disk' is checked it will delete the nested projects (expected). But in that case the delete nested project(s) option should be checked and disabled.

That would give the additional benefit that one would see which project locations get deleted.

NOTES:
- Since the second option depends on the first one, it should be indented.
- The state of the delete nested project option should be restored when the user disables the first option.
Comment 7 Mickael Istria CLA 2017-11-23 05:58:12 EST
(In reply to Dani Megert from comment #6)
> I found a major usability issue: When 'Delete project contents on disk' is
> checked it will delete the nested projects (expected). But in that case the
> delete nested project(s) option should be checked and disabled.
> That would give the additional benefit that one would see which project
> locations get deleted.

Makes sense

> NOTES:
> - Since the second option depends on the first one, it should be indented.

As the "nested project" option can be checked even when "delete" is unchecked, I' afraid that indenting may be confusing for some use-case (including the one that drove me to implement the feature: removing a chain of projects from workspace without deleting them).

> - The state of the delete nested project option should be restored when the
> user disables the first option.

Ok.
Comment 8 Dani Megert CLA 2017-11-23 06:00:30 EST
(In reply to Mickael Istria from comment #7)
> As the "nested project" option can be checked even when "delete" is
> unchecked, I' afraid that indenting may be confusing for some use-case
> (including the one that drove me to implement the feature: removing a chain
> of projects from workspace without deleting them).

I'm OK leaving it as is.
Comment 9 Eclipse Genie CLA 2017-11-23 07:47:46 EST
New Gerrit change created: https://git.eclipse.org/r/112165
Comment 11 Mickael Istria CLA 2017-11-24 09:34:39 EST
Hopefully it's fully done now. Thanks Dani and Lucas for you careful reviews!
Comment 12 Dani Megert CLA 2017-11-24 09:35:56 EST
(In reply to Mickael Istria from comment #11)
> Hopefully it's fully done now. Thanks Dani and Lucas for you careful reviews!

My pleasure!
Comment 13 Jiri Engelthaler CLA 2018-05-04 07:34:11 EDT
Hello Mickael.
  Can you add a preference option to be the newly added checkbox in the default state checked? May be it should be always checked for nested projects and for me it's a preferred and logical behavior.

Thank you.
Comment 14 Jiri Engelthaler CLA 2018-05-04 07:38:36 EDT
(In reply to Jiri Engelthaler from comment #13)
> May be it should be always checked for nested
> projects and for me it's a preferred and logical behavior.

At least in Hierarchical projects representation.
Comment 15 Mickael Istria CLA 2018-05-04 08:27:16 EDT
Can you please create a separate enhancement request for new requests?
Comment 16 Jiri Engelthaler CLA 2018-05-04 08:41:56 EDT
(In reply to Mickael Istria from comment #15)
> Can you please create a separate enhancement request for new requests?

OK. Bug 534366