Bug 52574 - Rendering of CBanner with only one child
Summary: Rendering of CBanner with only one child
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Veronika Irvine CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-19 21:44 EST by Nick Edgar CLA
Modified: 2004-05-13 16:55 EDT (History)
3 users (show)

See Also:


Attachments
Screen shot of browser example (81.06 KB, image/pjpeg)
2004-02-20 00:17 EST, Nick Edgar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2004-02-19 21:44:45 EST
build I20040219

RCP apps need the ability to hide workbench window controls like the menubar, 
coolbar, perspective switcher, and fast view docks.

The perspective switcher is the right child of a CBanner in the WorkbenchWindow 
layout (along with the CoolBar at left).

I've tried hiding the perspective switcher by only setting it as the right 
control if it should be shown, but the curve still appears in this case.

We should also consider how the window should look if they hide the coolbar but 
not the perspective switcher.  It should probably just take the whole row, with 
no curve.

Can CBanner be made to only draw the curve (and its tail) if both a right 
control and a left control (and/or a middle control) is set?  If there is only 
one control set, it would basically act like a composite.

I know it's possible to use different controls to get the layout as needed, but 
it would be better if CBanner handled this, since this would simplify our 
layout logic and since we may encounter cases where the perspective switcher 
gets turned on and off dynamically.
Comment 1 Nick Edgar CLA 2004-02-20 00:17:22 EST
Created attachment 8047 [details]
Screen shot of browser example

The attached screen shot shows how the browser example currently looks with the
perspective bar hidden.
Comment 2 Michael Van Meekeren CLA 2004-02-20 11:35:21 EST
OOBE Intro needs this too.
Comment 3 Veronika Irvine CLA 2004-02-25 11:39:00 EST
I think you should use a Composite insetad of a CBanner in the case where you 
only have one thing to show.

It affects not only the drawing of the swoosh but also the margins, 
computeSize, computeTrim etc, etc.
Comment 4 Veronika Irvine CLA 2004-05-13 16:55:52 EDT
Fixed.  Please reopen if you are not satisfied.