Bug 5222 - TVT: Software Update action set text is incorrectly separated
Summary: TVT: Software Update action set text is incorrectly separated
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Vlad Klicnik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-24 15:39 EDT by Dan Kehn CLA
Modified: 2002-01-23 21:21 EST (History)
0 users

See Also:


Attachments
Show View dialog display problem if string contains accelerator character (&) (21.69 KB, image/jpeg)
2001-11-07 15:19 EST, Dan Kehn CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Kehn CLA 2001-10-24 15:39:17 EDT
To reproduce (from TVT step 8.1, traditional Chinese):

1. Select Perspective > Customize...
2. Expand "Other"
3. Look at Software Updates in any DB language (e.g., simplified Chinese) or 
Spanish.  The text is not correctly displayed.  In Spanish, only the first word 
is shown.  In simplified Chinese, only "(S)" is displayed, i.e., the character 
glyph is lost.

The problem appears to stem from the usage of an accelerator character in the 
text string ("&Software Updates"):

   <actionSet
         label="%S_Software_Updates"
         visible="false"
         id="org.eclipse.update.internal.ui.UpdateManagerActionSet">

Apparently the tree view can't handle this sort of character in some languages.

However, there is a more fundamental problem.  In many languages, the noun and 
verb are not the same.  For example, "search" is both a noun and a verb in 
English.  However, in French, the noun is "recherche" and the verb 
is "rechercher".  In German and other languages, the difference is not as 
subtle, much like the difference between "look for" and "search" -- i.e., you 
can't treat "look for" as a noun and it would look silly as an action set name.

The action sets are normally named with a noun, the actions themselves are 
verbs.  In this specific case, the developer specified the same string for 
both.  Unfortunately, this also included an accelerator character (&S), which 
exposed this bug.

Suggested fix:

Separate the two into separate fields, as shown below:

(from org.eclipse.update/plugin.xml)
   <actionSet
         label="%S_Software_Updates"
         visible="false"
         id="org.eclipse.update.internal.ui.UpdateManagerActionSet">
      <action
            label="%S_Software_Updates_Action"
            class="org.eclipse.update.internal.ui.UMDialogAction"
            menubarPath="help/helpEnd"
            id="org.eclipse.update.internal.ui.UpdateManagerAction">
      </action>
   </actionSet>

and corresponding changes to org.eclipse.update\plugin.properties:

S_Eclipse_Update_Manager_Plugin = Install/Update Manager
# note: action set name
S_Software_Updates = Software Updates
# note: action set action
S_Software_Updates_Action_Set = &Software Updates...
S_Software_Updates_Preferences = Software Updates
Comment 1 Dan Kehn CLA 2001-10-26 10:21:01 EDT
Changed to v1.0.
Comment 2 Dan Kehn CLA 2001-11-07 15:19:31 EST
Created attachment 86 [details]
Show View dialog display problem if string contains accelerator character (&)
Comment 3 Dan Kehn CLA 2001-11-07 15:19:52 EST
FYI... here is a problem that is probably related, pointing to the possibility 
that accelerator characters in tree view's is problematic.

--------------------

Translation of "&PDE Runtime" to "PDE RANTAIMU(&P)" (in DBCS Japanese) in Show 
View dialog causes the text corrupted to "P)".
This problem has been bypassed by changing translation to "&PDE RANTAIMU".

See attached image.
Comment 4 Vlad Klicnik CLA 2002-01-22 13:09:08 EST
No longer applicable. The R1.0 update support is withdrawn in 2.0.
Comment 5 Dan Kehn CLA 2002-01-23 20:00:05 EST
Would you clarify a bit?  I see it in the project plan for 2.0 
(http://dev.eclipse.org/viewcvs/index.cgi/~checkout~/platform-update-
home/main.html).  Will this be updated to reflect this decommit?

This isn't an idle question, I'm on the Jumpstart team that also delivers a 
class that includes references to Software Update.  If it is being dropped, we 
will drop it from the class as well.

Thanks, Dan
Comment 6 Dan Kehn CLA 2002-01-23 21:21:33 EST
Nevermind, Jim D'Anjou pointed out that there's a new perspective that replaces 
the 1.0 version.  I took your response a bit too literally, sorry.

-- Dan