Community
Participate
Working Groups
To better handle some use-cases with working sets, it would be very convenient to provide a "Close all included projects" action on working set(s). It's also important that this action work also in case selection is multiple working sets.
Created attachment 270138 [details] Open and close projects contained in a working set
(In reply to Conrad Groth from comment #1) > Created attachment 270138 [details] > Open and close projects contained in a working set The attachment shows the context menu of a working set in the package explorer. It would be nice to have that feature also in the project explorer.
The naming of the action (in the Package Explorer) is wrong, see bug 522096.
(In reply to Dani Megert from comment #3) > The naming of the action (in the Package Explorer) is wrong, see bug 522096. You referenced this bug?
(In reply to Conrad Groth from comment #4) > (In reply to Dani Megert from comment #3) > > The naming of the action (in the Package Explorer) is wrong, see bug 522096. > > You referenced this bug? Thanks for noticing. It's bug 526946.
New Gerrit change created: https://git.eclipse.org/r/112098
Thanks Lucas for the patch and Conrad for the review! Let's keep this bug open to track the addition to N&N.
Gerrit change https://git.eclipse.org/r/112098 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=18df0075dfd74d07ae9c384ede85e94233b36cdd
New Gerrit change created: https://git.eclipse.org/r/112392
Gerrit change https://git.eclipse.org/r/112392 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=ed27e37c60f74fea16fe8f539e77961d2f643482
N&N applied.
This doesn't work for me on 'Other Projects' working set.
(In reply to Dani Megert from comment #12) > This doesn't work for me on 'Other Projects' working set. I think this is actually a larger issue and should be addressed in a different bug. The "Other Projects" Working Set isn't a WS, it is actually just an empty object that is referenced, so does not set off any of the "is this a IWorkingSet" tests.
(In reply to Lucas Bullen from comment #13) > I think this is actually a larger issue and should be addressed in a > different bug. The "Other Projects" Working Set isn't a WS, it is actually > just an empty object that is referenced, so does not set off any of the "is > this a IWorkingSet" tests. Could the test easily be changed into "can adapt to an array of projects", and to have adapters to turn an IWorkingSet and the OtherProjects thing into such arrays of project? That said, I support the idea of a separate bug.
(In reply to Mickael Istria from comment #14)> That said, I support the idea of a separate bug. Yeah, it's easy to provide a half-finished fix and then outsource the compete one. Do whatever you see fit. I don't consider this bug to be fixed though.
(In reply to Dani Megert from comment #15) > Yeah, it's easy to provide a half-finished fix and then outsource the > compete one. Do whatever you see fit. I don't consider this bug to be fixed > though. Iterative development FTW! Bugs with scope that goes increasing and increasing are often dis-motivating and make tracking progress and value delivery harder. Iterative scales better and allows to re-prioritize things with more agility. That's the idea of creating another bug: we consider a big part of the value as properly shipped, and create a new issue to consider some additional value for later, when it becomes top-priority for a contributor. This "Half-finished work" already provides all the value I expected to be produced when I reported the bug, and I believe it also covers Conrad's use case. The patch answering the initial request is I believe a proper reason to mark this bug as RESOLVED ;) Bug 528035 new tracks the missing bits you've identified.
Verified in I20180122-0800
