Bug 521958 - Platform debug to register contribution to Generic Editor
Summary: Platform debug to register contribution to Generic Editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M3   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, noteworthy
Depends on:
Blocks: 521960
  Show dependency tree
 
Reported: 2017-09-06 16:45 EDT by Mickael Istria CLA
Modified: 2017-11-06 10:32 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-09-06 16:45:09 EDT 
Debug could provide a default Hover support so that adopters would only have to provide an adapter from a text selection to some IVariable to automatically get the value displayed and browsable.
Comment 1 Eclipse Genie CLA 2017-09-06 16:46:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/104614
Comment 2 Mickael Istria CLA 2017-09-06 16:48:24 EDT 
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/104614

With this patch, adopters can simply provide an IAdapterFactory from ITextSelection to IVariable. The Generic Debug hover would use it to resolve the hovered text to a debug model and can then show the value in hover.
Comment 3 Sarika Sinha CLA 2017-09-06 23:24:59 EDT 
Thanks Mickael, will look into this after Java 9 release in M3.
Comment 4 Eclipse Genie CLA 2017-10-11 06:17:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/106566
Comment 5 Sarika Sinha CLA 2017-10-12 01:39:31 EDT 
Code looks fine now but just want to understand, how hover will work with java file. I created a java file and opened with Generic editor. I can't add a breakpoint to debug so I added a breakpoint while opening with java editor. Now I can see the breakpoint in the Generic editor as well. Now If I launch it will debug configuration, it opens the java editor to debug.
So how do I test that with this implementation, debug hover works with java file?
Comment 6 Mickael Istria CLA 2017-10-12 02:42:12 EDT 
While debug session hits a breakpoint, roght-click > Open With > Generic Editor and hover on a variable (it requires JDT patch for #521960). If you want another client to test, you can try BlueSky for Eclipse which enables same workflow for JS files.
Comment 8 Sarika Sinha CLA 2017-10-12 02:53:00 EDT 
Thanks Mickael for the contribution.
Comment 9 Dani Megert CLA 2017-10-12 04:36:42 EDT 
Please pay more attention to details.

- Checking out org.eclipse.debug.ui into a new workspace results in an error on the MANIFEST.MF.

- Copyright is missing on the new files.

- Maybe other things?
Comment 10 Sarika Sinha CLA 2017-10-12 05:05:00 EDT 
Mikael,
Please add the copyright and export the new package in Maniifest.


Thanks Dani.
Comment 11 Eclipse Genie CLA 2017-10-12 10:40:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/109917
Comment 12 Eclipse Genie CLA 2017-10-12 14:24:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/109943
Comment 14 Sarika Sinha CLA 2017-10-16 05:35:46 EDT 
http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=e8c072e5efe116a54bc748b60241238a87d9e44a

Added Commented filter for bundle version bump of minor version.
Comment 15 Eclipse Genie CLA 2017-10-16 10:48:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/110142
Comment 17 Sarika Sinha CLA 2017-10-20 21:40:57 EDT 
Eclipse SDK
Version: Photon (4.8)
Build id: I20171019-2000
OS: Windows 7, v.6.1, x86_64 / win32
Comment 18 Eclipse Genie CLA 2017-11-06 10:03:12 EST 
New Gerrit change created: https://git.eclipse.org/r/111062