Bug 521921 - Redundant Compute Differences
Summary: Redundant Compute Differences
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-06 07:37 EDT by Ed Willink CLA
Modified: 2020-05-12 07:19 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2017-09-06 07:37:55 EDT 
Oxygen.

If a Java file is being edited, and if it has also been compared using a GIT comparison, the UI may stall sometimes without explanation. Sometimes there is a clue; the status bar shows "Computing differences". For larger files the stall may be quite disconcerting.

There is absolutely no point wasting CPU time on a comparison that is not visible.
Comment 1 Stephan Herrmann CLA 2017-09-06 09:20:53 EDT 
Let's see who could possibly in charge of this? Platform/Team, EGit, Platform/Compare?
Comment 2 Stephan Herrmann CLA 2017-09-06 09:22:17 EDT 
FWIW, sometimes, during save in a Java editor for a fraction of a second I see the divider between left and right versions rendered despite the compare editor being invisible. Might be a clue towards the cause?
Comment 3 Ed Willink CLA 2017-09-06 10:26:41 EDT 
(In reply to Ed Willink from comment #0)
> There is absolutely no point wasting CPU time on a comparison that is not
> visible.

AND even if you do waste time, it should not be wasted on the UI thread.

(Perhaps the UI thread hang is yet another symptom of everything waits for a save.)
Comment 4 Eclipse Genie CLA 2020-04-16 13:39:42 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Stephan Herrmann CLA 2020-04-16 13:53:10 EDT 
I observed symptom comment 2 just yesterday in the latest and greatest ...
Comment 6 Lars Vogel CLA 2020-05-11 15:53:31 EDT 
Please reopen if the problem still persists.
Comment 7 Ed Willink CLA 2020-05-12 04:57:42 EDT 
(In reply to Lars Vogel from comment #6)
> Please reopen if the problem still persists.

Please read comment #5.
Comment 8 Stephan Herrmann CLA 2020-05-12 07:19:52 EDT 
(In reply to Ed Willink from comment #7)
> (In reply to Lars Vogel from comment #6)
> > Please reopen if the problem still persists.
> 
> Please read comment #5.

+1