Bug 52149 - [ViewMgmt] Tab width should not change when gaining/loosing focus
Summary: [ViewMgmt] Tab width should not change when gaining/loosing focus
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 56492 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-02-16 09:35 EST by Philipe Mulet CLA
Modified: 2019-09-06 15:32 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2004-02-16 09:35:11 EST
Build 3.0M7

In new look, a tab width is bigger when it has focus (drawing the icon + S-
curve on its right edge). In presence of a number of tabs stacked together, 
each time a different tab is selected, all subsequent tabs are moved 
horizontally to readjust, and suggests that more than just a focus change did 
occur.
Comment 1 Philipe Mulet CLA 2004-02-16 09:36:29 EST
Having all tabs be the same size (active or inactive) would make total sense to 
me.
Comment 2 Grant Gayed CLA 2004-02-17 15:42:42 EST
Changing to enhancement since this was by design.  VI to consider.
Comment 3 Veronika Irvine CLA 2004-02-17 18:36:31 EST
This was an intentional choice by the graphic designer - the idea was to 
reduce clutter by not having images on all tabs.
Comment 4 Philipe Mulet CLA 2004-02-20 07:27:10 EST
I agree with removing the icon when loosing focus. And in the new new look (as 
of 20040219), it seems a bit better. 

I can see that the asymetrical tab looks good when on the left, but once 
stacked amongst others, IMHO it is not so nice.

Not critical in any mean, as observed earlier.
Comment 5 Dan Berindei CLA 2004-03-28 17:31:02 EST
+1 for having all tabs the same size.

The editor tabs are ok with the traditional tab style active, but the view tabs
keep moving (and annoying me), since the focused one still has extra space for
the icon and the close button.

I would suggest having the icon shown in all view tabs (and maybe draw the
S-curve a bit over the next tab's icon when the new tab style is active). As for
the close button, I would suggest taking it out of the tab and putting it to the
right side of the tab bar, since it would be too much to reserve space for it in
every view tab.
Comment 6 Veronika Irvine CLA 2004-09-24 15:55:05 EDT
The CTabFolder supports the following combinations:

1) Have or do not have "S" on right side of selected tab
2) Always show close or only show close on selected tab
3) Always show image or only show image on selected tab

The default behaviour of CTabFolder is no "S", always show close and always 
show image.

Eclipse chooses to change from the default settings as follows:
For Views: show "S", only show image and close for selected tab.  
For editors: show "S", show image and show close button for all tabs.

The way CTabFolder is used needs to be decided by the UI team.  Moving to them.

Comment 7 Nick Edgar CLA 2004-09-24 17:08:30 EDT
With the current settings and CTabFolder behaviour, the view and editor tabs are
much more stable than before.
Closing as WORKSFORME. 
Comment 8 Stefan Xenos CLA 2004-09-24 20:07:08 EDT
Nick, this is still occurring in 3.1 M2 for views.

For editors, the tab width remains constant if you select
workbench->appearance->Show traditional style tabs... but view widths are still
shifting around.
Comment 9 Nick Edgar CLA 2004-09-27 10:23:29 EDT
Hmm, view tabs seem pretty stable for me using traditional tabs (on Win2K). 
While the selected tab does change size, only the previously selected and newly
selected tabs are affected when switching.  Other tabs are unaffected.
Comment 10 Stefan Xenos CLA 2004-09-27 18:51:32 EDT
Re: comment 9

That's correct: only the previously selected and newly selected tab will change
size. Any tab between the two will move toward the previously selected tab.
However, that is precisely the behavior being described by this PR.
Comment 11 Boris Bokowski CLA 2007-06-19 16:50:21 EDT
*** Bug 56492 has been marked as a duplicate of this bug. ***
Comment 12 Boris Bokowski CLA 2009-11-11 17:30:51 EST
Remy is now responsible for watching the [ViewMgmt] category.
Comment 13 Eclipse Webmaster CLA 2019-09-06 15:32:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.