521387 – [Gtk3] Alt+Enter performs two actions in Package Explorer

Bug 521387 - [Gtk3] Alt+Enter performs two actions in Package Explorer

Summary: [Gtk3] Alt+Enter performs two actions in Package Explorer

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.8
Hardware:	PC Linux

Importance:	P2 normal (vote)
Target Milestone:	4.8 M6
Assignee:	Leo Ufimtsev
QA Contact:	Leo Ufimtsev

URL:
Whiteboard:
Keywords:	regression, triaged

Depends on:
Blocks:

Reported:	2017-08-24 13:01 EDT by Stephan Herrmann
Modified:	2018-03-07 16:24 EST (History)
CC List:	3 users (show)

See Also:	508245 Gerrit Change Git Commit TreeDefaultSelectionOrder

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephan Herrmann

2017-08-24 13:01:07 EDT

1. Select a project in Package Explorer
2. Press Alt+Enter to bring up the Project Properties

=> Additionally, the expand-state of the project is toggled.

Bug does not occur in Neon.3, but occurs in Oxygen (same machine).

Comment 1 Dani Megert

2017-08-25 08:45:19 EDT

Works fine on Windows.

Comment 2 Leo Ufimtsev

2017-08-25 09:43:57 EDT

This behavior appears to be introduced by one of my patches:
https://git.eclipse.org/r/#/c/87090/

I've checked out the commit before that patch, and alt+enter only opens properties.
With the patch, alt+enter opens properties and also expands tree.

~Need to investigate.

(In reply to Dani Megert from comment #1)
> Works fine on Windows.

Thank you for testing that on windows.

Comment 3 Eclipse Genie

2018-02-14 14:59:07 EST

New Gerrit change created: https://git.eclipse.org/r/117390

Comment 4 Eclipse Genie

2018-02-14 15:41:51 EST

Gerrit change https://git.eclipse.org/r/117390 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=42fb9859bce0c7cfca6625ecd61f7aecc8bf0bb2

Comment 5 Leo Ufimtsev

2018-02-14 15:42:49 EST

Fixed 2 bugs submitted by Stephan in 1 day.

~Things I do to please Stephan he he.

Comment 6 Stephan Herrmann

2018-02-14 16:27:41 EST

(In reply to Leo Ufimtsev from comment #5)
> Fixed 2 bugs submitted by Stephan in 1 day.
> 
> ~Things I do to please Stephan he he.

You get a gift card of the value of two JDT bug fixes :)

Comment 7 Leo Ufimtsev

2018-03-07 16:24:30 EST

Verified. Works as expected in latest master eclipse.