Bug 521146 - [generic editor] When no processor does return a completion, return the token completion proposals
Summary: [generic editor] When no processor does return a completion, return the token...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-19 03:17 EDT by Mickael Istria CLA
Modified: 2018-09-12 18:37 EDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-08-19 03:17:05 EDT 
From https://github.com/mickaelistria/eclipse-bluesky/issues/8
Currently, the "existing token completion processor" is enabled on the file when no other processor is active. However, it would be better to query it whenever none of the existing processors do return result.
Comment 1 Angelo ZERR CLA 2017-08-21 05:33:30 EDT 
+1 !

I love this idea.
Comment 2 Mickael Istria CLA 2017-08-21 16:48:40 EDT 
This actually happens to be complex to implement: generic editor uses (fairly) asynchronous content assist with multiple processors. With this, hooking a fall-back strategy becomes quite hard as it requires to go deep into hacking of the ContentAssistant instance, at the limit of what JFace allows...
Comment 3 Dani Megert CLA 2018-05-24 12:52:32 EDT 
Removing target milestone for all bugs that are not major or above.
Comment 4 Dani Megert CLA 2018-05-25 04:07:52 EDT 
> Removing target milestone for all bugs that are not major or above.

Of course I meant "major or below".

Sorry for the noise!