520422 – Listener methods of StyledText not covered by unit tests

Bug 520422 - Listener methods of StyledText not covered by unit tests

Summary: Listener methods of StyledText not covered by unit tests

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.8
Hardware:	PC All

Importance:	P3 enhancement (vote)
Target Milestone:	4.8 M2
Assignee:	Arne Deutsch
QA Contact:	Leo Ufimtsev

URL:
Whiteboard:
Keywords:	test

Depends on:
Blocks:

Reported:	2017-08-01 10:50 EDT by Arne Deutsch
Modified:	2017-09-14 04:42 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arne Deutsch

2017-08-01 10:50:32 EDT

The methods "addCaretListener" and "addWordMovementListener" of "StyledText" are not covered by tests that are inside the "AllWidgetsTests" suite. Especially they are not covered by any test case inside "Test_org_eclipse_swt_custom_StyledText". For better test coverage it would be good to add test cases that call these methods and verify that the listeners are called.

Comment 1 Eclipse Genie

2017-08-01 10:52:22 EDT

New Gerrit change created: https://git.eclipse.org/r/102318

Comment 2 Eclipse Genie

2017-08-09 15:59:07 EDT

Gerrit change https://git.eclipse.org/r/102318 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5d47be650ef6f2701e7d613b93ddf27ee2c0fc94

Comment 3 Leo Ufimtsev

2017-08-09 16:00:32 EDT

Will review this and other jUnit patches tomorrow-ish.

Comment 4 Sravan Kumar Lakkimsetti

2017-09-14 04:42:08 EDT

Verified in  I20170913-2000