Bug 519916 - [maven][test] pom.xml doesn't have to specify webkit as default browser anymore
Summary: [maven][test] pom.xml doesn't have to specify webkit as default browser anymore
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Leo Ufimtsev CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2017-07-19 17:55 EDT by Leo Ufimtsev CLA
Modified: 2017-08-01 10:32 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2017-07-19 17:55:59 EDT
In tests/../pom.xml, we hard-code the default browser to be webkit. This causes maven tests related to Browser to fail on Windows as it's trying to use webkit instead of I.e, which by default is not installed.

I.e:
<argLine> .. -Dorg.eclipse.swt.browser.DefaultType=webkit ... </argLine>

Since XUL Runner is removed from codebase, hard-coding webkit is no longer needed. As of recently:
- On Linux, webkit is default 
- On Cocoa, webkit is default
- On Win,   I.E is default

Thus the hard-coding can be safely removed without breakage.
~Patch en route.
Comment 1 Eclipse Genie CLA 2017-07-19 20:19:58 EDT
New Gerrit change created: https://git.eclipse.org/r/101610