519525 – Open resource should use highlight matches based on substrings

Bug 519525 - Open resource should use highlight matches based on substrings

Summary: Open resource should use highlight matches based on substrings

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.3
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.8 M1
Assignee:	Christoph Stanik
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, helpwanted, noteworthy, usability

Depends on:
Blocks:	520250 520251
	Show dependency tree

Reported:	2017-07-11 16:56 EDT by Lars Vogel
Modified:	2017-07-27 06:31 EDT (History)
CC List:	8 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Screenshot from Open Type (67.88 KB, image/png) 2017-07-11 16:56 EDT, Lars Vogel	no flags	Details
Screenshot Open Resource (129.38 KB, image/png) 2017-07-11 16:57 EDT, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2017-07-11 16:56:02 EDT

Created attachment 269318 [details]
Screenshot from Open Type

Open Type uses styles to highlight the matching Java class. Open resources should use the same.
g

Comment 1 Lars Vogel

2017-07-11 16:57:04 EDT

Created attachment 269319 [details]
Screenshot Open Resource

Comment 2 Lars Vogel

2017-07-11 17:02:15 EDT

Gerrit patches are welcome

Comment 3 Eclipse Genie

2017-07-17 12:51:20 EDT

New Gerrit change created: https://git.eclipse.org/r/101370

Comment 4 Eclipse Genie

2017-07-17 15:43:31 EDT

Gerrit change https://git.eclipse.org/r/101370 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=131c5e405cd7923cc7c3177c46fa2a473f059290

Comment 5 Lars Vogel

2017-07-17 15:44:03 EDT

Thanks, Christoph, looks very good to me and this is extremely useful.

Comment 6 Eclipse Genie

2017-07-25 04:09:09 EDT

New Gerrit change created: https://git.eclipse.org/r/101879

Comment 7 Eclipse Genie

2017-07-25 05:18:40 EDT

Gerrit change https://git.eclipse.org/r/101879 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3d763c5c1f21f5de2806fd45bba976b9e565875c

Comment 8 Till Brychcy

2017-07-25 14:26:10 EDT

Thanks for working on this.

Only substring matches are implemented, the following cases are missing (which are the cases when highlighting would be most useful):

- CamelCase.
- Patterns (like prefix*moretext)

In "Open Type", all matching kinds are handled correctly.

I'm setting the status to REOPENED so this doesn't get overlooked, because I really think this should either be completely implemented or reverted as in the current state, this feels very broken.

Comment 9 Lars Vogel

2017-07-25 15:06:59 EDT

(In reply to Till Brychcy from comment #8)
> Thanks for working on this.
> 

> I'm setting the status to REOPENED so this doesn't get overlooked, because I
> really think this should either be completely implemented or reverted as in
> the current state, this feels very broken.

I suggest to handle this via a new bug, substring matching is IMHO already useful.

Comment 10 Lars Vogel

2017-07-27 06:28:41 EDT

(In reply to Lars Vogel from comment #9)
> I suggest to handle this via a new bug, substring matching is IMHO already
> useful.

I adjusted the bug message header to reflect the actual work and will open new two news bugs for the other highlighting options.