Bug 518871 - Wrong first or last GMF bendpoints in case of Straight routing style with only one segment
Summary: Wrong first or last GMF bendpoints in case of Straight routing style with onl...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.1.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Julien Dupont CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 518073
Blocks: 517437 518440 518441 518870
  Show dependency tree
 
Reported: 2017-06-28 04:46 EDT by Laurent Redor CLA
Modified: 2017-11-08 03:36 EST (History)
2 users (show)

See Also:

Attachments
Use case to reproduce (74.00 KB, application/x-zip-compressed)
2017-09-20 06:06 EDT, Julien Dupont CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2017-06-28 04:46:42 EDT 
+++ This bug was initially created as a clone of Bug #518073 +++

In case of an edge with a Straight routing style and with only one segment, the GMF bendpoints are false if the edge is "reverted". For example, in the case of "1-beforeMovingEdge.png", the GMF bendpoints are correct (same as draw2d). But if the node C2 is moved on left of C1, the GMF bendpoints are wrong (see "2-afterMovingEdge.png").
These false bendpoints can be problematic for other calculations (like label location).

Steps to reproduce:
* Open the diagram "newDiag3" of the project "SampleProject" (from SampleProject.zip)
* Open the "Sirius Debugging View" (from plugin org.eclipse.sirius.ui.debug)
* Select the edge between C1 and C2
* In the "Sirius Debugging View", the GMF computed points are the same as Draw2D points.
* Move C2 to the left of C1
* KO: In the "Sirius Debugging View", the GMF computed points are not the same as Draw2D points.
Comment 1 Eclipse Genie CLA 2017-07-04 04:34:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/100601
Comment 3 Julien Dupont CLA 2017-09-20 06:06:33 EDT 
Created attachment 270272 [details]
Use case to reproduce

To validate it, put plugins directory in droppins directory
Comment 4 Pierre-Charles David CLA 2017-11-08 03:36:37 EST 
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.