Bug 518073 - Wrong first or last GMF bendpoints in case of Straight routing style with only one segment
Summary: Wrong first or last GMF bendpoints in case of Straight routing style with onl...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1.6   Edit
Assignee: Laurent Redor CLA
QA Contact: Guillaume Doux CLA
URL:
Whiteboard: diagram gmf edges
Keywords: triaged
Depends on:
Blocks: 517437 518440 518441 518870 518871
  Show dependency tree
 
Reported: 2017-06-09 09:41 EDT by Laurent Redor CLA
Modified: 2017-07-07 07:25 EDT (History)
2 users (show)

See Also:


Attachments
sampleProject.zip for steps to reproduce (6.40 KB, application/x-zip-compressed)
2017-06-09 09:41 EDT, Laurent Redor CLA
no flags Details
1-beforeMovingEdge.png (36.87 KB, image/png)
2017-06-09 09:41 EDT, Laurent Redor CLA
no flags Details
2-afterMovingEdge.png (36.56 KB, image/png)
2017-06-09 09:42 EDT, Laurent Redor CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2017-06-09 09:41:17 EDT
Created attachment 268844 [details]
sampleProject.zip for steps to reproduce

In case of an edge with a Straight routing style and with only one segment, the GMF bendpoints are false if the edge is "reverted". For example, in the case of "1-beforeMovingEdge.png", the GMF bendpoints are correct (same as draw2d). But if the node C2 is moved on left of C1, the GMF bendpoints are wrong (see "2-afterMovingEdge.png").
These false bendpoints can be problematic for other calculations (like label location).

Steps to reproduce:
* Open the diagram "newDiag3" of the project "SampleProject" (from SampleProject.zip)
* Open the "Sirius Debugging View" (from plugin org.eclipse.sirius.ui.debug)
* Select the edge between C1 and C2
* In the "Sirius Debugging View", the GMF computed points are the same as Draw2D points.
* Move C2 to the left of C1
* KO: In the "Sirius Debugging View", the GMF computed points are not the same as Draw2D points.
Comment 1 Laurent Redor CLA 2017-06-09 09:41:51 EDT
Created attachment 268845 [details]
1-beforeMovingEdge.png
Comment 2 Laurent Redor CLA 2017-06-09 09:42:11 EDT
Created attachment 268846 [details]
2-afterMovingEdge.png
Comment 3 Eclipse Genie CLA 2017-06-09 17:01:11 EDT
New Gerrit change created: https://git.eclipse.org/r/99055
Comment 5 Guillaume Doux CLA 2017-06-30 10:49:00 EDT
Validated with Sirius 4.1.6-S20170628-064814
Comment 6 Pierre-Charles David CLA 2017-07-07 07:25:18 EDT
Available in Sirius 4.1.6, see https://wiki.eclipse.org/Sirius/4.1.6 for details.