Community
Participate
Working Groups
"Apply and Close" doesn't make sense for info-only properties pages. - Run or Debug a launch configuration. - In the Debug view, select the process. - Execute the "Properties" command. => A properties dialog without anything to apply is opened. "Apply and Close" doesn't make sense in this context. In older releases there was an "OK" button (totally made sense), and redundant "Cancel" button (that wasn't wrong).
New Gerrit change created: https://git.eclipse.org/r/102776
I pushed a fix. I override the createButton method in WorkbenchPreferenceDialog and PropertyDialog. For a PropertyDialog, the button label is only "Close". I think, we can maybe remove the "Cancel" button now?! What do you think? In PreferenceDialog I changed the button label back to "ok" for now. I think "close" doesn't fit here.
(In reply to David Weiser from comment #2) > I think, we can maybe remove the "Cancel" button now?! Why? I do sometimes use the Cancel button and I'm not aware of a compaint about this button.
> I think, we can maybe remove the "Cancel" button now?! What do you think? Don't remove, please. Very often need look some options without apply changes.
No, sorry, that was a misunderstanding. I don't want to remove the Cancel button from WorkbenchPreferenceDialog but from PropertyDialog.
(In reply to David Weiser from comment #5) > I don't want to remove the Cancel > button from WorkbenchPreferenceDialog but from PropertyDialog. Same -1 from me ;) I do use this cancel button often and don't see any value in removing it, on the contrary.
Ok. I am not sure about the usage of PropertyDialog. If it is only used to present properties without the ability to change them (like Markus example), only "Close" would be fine I think.
(In reply to David Weiser from comment #7) > Ok. I am not sure about the usage of PropertyDialog. If it is only used to > present properties without the ability to change them (like Markus example), > only "Close" would be fine I think. Ok, got it. However, how can you distinguish whether a PropertyDialog in general only contains readonly pages in order to evaluate whether it's ok to skip the "cancel" button or not, or to show only "close" instead of "apply and close"? I have the impression that it's not something we can detect in general so the appropriate fix is to change this per dialog instance if we're sure it's read-only. However, even for debug, are we sure all property dialog on a debugged process (from whichever language and so on) is read-only?
From the discussion in the Gerrit: ---- Mickael Istria Patch Set 1: Code-Review-2 All those dialogs may allow edition and may have "Apply and Close" and "Cancel" useful to them. Unless we have a way to detect whether a dialog can host changes or not, it's better to keep things as it for consistency and to not break adopter use-cases (who can usually contribute editable pages to those dialogs) --- I agree, marking as wontfix.
