Bug 518239 - [JUnit 5] Feature patch for JUnit 5 support on 4.7
Summary: [JUnit 5] Feature patch for JUnit 5 support on 4.7
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: BETA JUnit 5   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 517063 518185 520876
Blocks: 488566 520623
  Show dependency tree
 
Reported: 2017-06-14 08:44 EDT by Noopur Gupta CLA
Modified: 2017-09-12 12:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2017-06-14 08:44:10 EDT 
We need a feature patch for JUnit 5 support in Eclipse.

It will use the BETA_JUNIT5 branches of eclipse.jdt.ui and eclipse.jdt (see bug 518185).

The JUnit 5 JARs are added to Orbit via bug 517063.

For JUnit 5 M4 JARs in Orbit, see https://git.eclipse.org/r/#/c/97765.
Comment 1 Noopur Gupta CLA 2017-06-29 09:08:54 EDT 
The feature patch has to be applied on Eclipse 4.7 release build.
Comment 2 Noopur Gupta CLA 2017-07-06 02:53:42 EDT 
The JUnit 5 team released Milestone 5 on July 4, 2017. 

The corresponding Gerrit has been merged in Orbit for JUnit 5 M5 JARs. See bug 517063 comment#7.

Since we haven't created a feature patch for M4 yet, we can directly create the feature patch for M5 now.
Comment 3 Eclipse Genie CLA 2017-07-06 07:35:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/100826
Comment 5 Eclipse Genie CLA 2017-07-06 07:52:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/100830
Comment 7 Noopur Gupta CLA 2017-07-10 11:04:13 EDT 
Sravan, as requested, listing the plug-ins that are currently required in the feature patch from BETA_JUNIT5 branch of eclipse.jdt.ui repository:

org.eclipse.jdt.junit
org.eclipse.jdt.junit.core
org.eclipse.jdt.junit.runtime
org.eclipse.jdt.junit4.runtime
org.eclipse.jdt.junit5.runtime 
org.eclipse.jdt.ui
org.eclipse.jdt.ui.tests

We will need to update this list if more plug-ins are required later. Hence, it might be good to use all the plug-ins from BETA_JUNIT5 branch now itself, if that doesn't have any other issues.
Comment 9 Eclipse Genie CLA 2017-07-11 04:56:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/101039
Comment 11 Eclipse Genie CLA 2017-07-11 05:17:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/101040
Comment 13 Eclipse Genie CLA 2017-07-27 10:13:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/102091
Comment 14 Noopur Gupta CLA 2017-07-27 10:14:22 EDT 
(In reply to Eclipse Genie from comment #13)
> New Gerrit change created: https://git.eclipse.org/r/102091

Updated with JUnit 5.0.0-M6 JARs.
Comment 16 Noopur Gupta CLA 2017-07-31 09:14:17 EDT 
FYI, JUnit 5.0.0-RC2 has been released on 30 July. 

I think it doesn't make sense to request for CQs and Orbit JARs for JUnit 5.0.0-RC2 until we have a working update site for JUnit 5 support which consumes those JARs. Hence, I will wait before proceeding with JUnit 5.0.0-RC2 CQs and Orbit JARs.

Sravan, please let us know if you need anything else for creating the update site.
Comment 17 Noopur Gupta CLA 2017-08-01 08:17:54 EDT 
(In reply to Noopur Gupta from comment #16)
> Sravan, please let us know if you need anything else for creating the update
> site.

Sravan, can you please list down the required changes that were discussed offline so that I can work on them? I remember backporting the changes from eclipse-sdk-prereqs.target to R4_7 branch and some version changes(?).
Comment 18 Sravan Kumar Lakkimsetti CLA 2017-08-02 01:19:43 EDT 
(In reply to Noopur Gupta from comment #17)
> (In reply to Noopur Gupta from comment #16)
> > Sravan, please let us know if you need anything else for creating the update
> > site.
> 
> Sravan, can you please list down the required changes that were discussed
> offline so that I can work on them? I remember backporting the changes from
> eclipse-sdk-prereqs.target to R4_7 branch and some version changes(?).

You need to update prereqs file for 4_7 branch and update pom versions to 4.7.1 in beta_junit5 branch
Comment 19 Eclipse Genie CLA 2017-08-02 04:17:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/102343
Comment 20 Eclipse Genie CLA 2017-08-02 04:31:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/102344
Comment 21 Eclipse Genie CLA 2017-08-02 04:32:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/102345
Comment 22 Eclipse Genie CLA 2017-08-02 04:33:36 EDT 
Gerrit change https://git.eclipse.org/r/102345 was merged to [BETA_JUNIT5].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.git/commit/?id=0be6965c572e9feb7d06020849df91db2cc618e2
Comment 24 Eclipse Genie CLA 2017-08-02 05:00:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/102352
Comment 27 Eclipse Genie CLA 2017-08-03 02:42:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/102433
Comment 28 Eclipse Genie CLA 2017-08-03 02:44:00 EDT 
Gerrit change https://git.eclipse.org/r/102433 was merged to [BETA_JUNIT5].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.git/commit/?id=db82b3c7d59bba474791a5d9f9d4ba30cefe4bbf
Comment 29 Eclipse Genie CLA 2017-08-03 06:55:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/102445
Comment 31 Noopur Gupta CLA 2017-08-07 09:45:10 EDT 
We now have the U-build and update site available for JUnit 5 support in Eclipse listed here: http://download.eclipse.org/eclipse/downloads/YIndex.php.

The wiki page has been updated: 
https://wiki.eclipse.org/JDT_UI/JUnit_5.
Comment 32 Eclipse Genie CLA 2017-08-10 03:12:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/102832
Comment 33 Noopur Gupta CLA 2017-08-10 03:14:39 EDT 
(In reply to Eclipse Genie from comment #32)
> New Gerrit change created: https://git.eclipse.org/r/102832

This is to use JUnit 5 RC2 JARs.
Comment 35 Eclipse Genie CLA 2017-08-21 06:13:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/103365
Comment 36 Eclipse Genie CLA 2017-08-21 06:20:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/103366
Comment 38 Eclipse Genie CLA 2017-08-25 15:36:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/103716
Comment 39 Noopur Gupta CLA 2017-08-25 15:40:44 EDT 
(In reply to Eclipse Genie from comment #38)
> New Gerrit change created: https://git.eclipse.org/r/103716

This is to use JUnit 5 RC3 JARs. 

Dani/Sravan, could you please submit this change?
Comment 41 Eclipse Genie CLA 2017-09-01 08:58:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/104172
Comment 43 Eclipse Genie CLA 2017-09-12 06:12:12 EDT 
New Gerrit change created: https://git.eclipse.org/r/104934
Comment 44 Noopur Gupta CLA 2017-09-12 06:13:00 EDT 
(In reply to Eclipse Genie from comment #43)
> New Gerrit change created: https://git.eclipse.org/r/104934

This adds JUnit 5 GA bundles.
Comment 46 Eclipse Genie CLA 2017-09-12 12:24:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/104992