517470 – Switch to debug perspective should use verbs instead of "OK".

Bug 517470 - Switch to debug perspective should use verbs instead of "OK".

Summary: Switch to debug perspective should use verbs instead of "OK".

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	4.3
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.8 M1
Assignee:	Sarika Sinha
QA Contact:

URL:
Whiteboard:
Keywords:	usability

Depends on:
Blocks:

Reported:	2017-05-30 16:35 EDT by Lars Vogel
Modified:	2017-08-01 02:46 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Screenshot (27.25 KB, image/png) 2017-05-30 16:36 EDT, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2017-05-30 16:35:54 EDT

See Bug 513882 for related work.

Comment 1 Lars Vogel

2017-05-30 16:36:14 EDT

David, please provide a patch.

Comment 2 Lars Vogel

2017-05-30 16:36:51 EDT

Created attachment 268645 [details]
Screenshot

Comment 3 Eclipse Genie

2017-06-13 02:26:26 EDT

New Gerrit change created: https://git.eclipse.org/r/99194

Comment 4 Eclipse Genie

2017-07-10 03:05:54 EDT

Gerrit change https://git.eclipse.org/r/99194 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=ba40c99b85785a8844de6e4704546274345eb362

Comment 5 Sarika Sinha

2017-07-10 04:37:17 EDT

Thanks Lars!!

Comment 6 Andrey Loskutov

2017-07-26 05:34:45 EDT

This caused regresison: the user can't save the "Cancel" anymore, so the dialog appears all the time even if it is set to "save my choice"!

We can't use "Cancel" because MessageDialog *explicitly ignores* "Cancel" button and does NOT save the choice.

I will replace Cancel with No, patch follows.

Comment 7 Eclipse Genie

2017-07-26 05:35:58 EDT

New Gerrit change created: https://git.eclipse.org/r/101984

Comment 8 Eclipse Genie

2017-07-26 05:54:32 EDT

Gerrit change https://git.eclipse.org/r/101984 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=7a313518037770c1d605ae22b0943d8cbc8079ac

Comment 9 Sarika Sinha

2017-07-26 06:15:34 EDT

Thanks Andrey!!

Comment 10 Sarika Sinha

2017-08-01 01:57:04 EDT

Verified using
Eclipse SDK
Version: Photon (4.8)
Build id: I20170731-2000
OS: Windows 7, v.6.1, x86_64 / win32