Community
Participate
Working Groups
4.7 RC2 and earlier builds.
Lakshmi, please check whether there's an obvious difference on Mac compared to other platforms where the tests pass fine.
I work both on Mac and on Win. When I get the source code under MacOS, I see an error that I cannot see in Windows. The issue is reported in Bug 517222.
(In reply to Patrik Suzzi from comment #2) > I work both on Mac and on Win. When I get the source code under MacOS, I see > an error that I cannot see in Windows. The issue is reported in Bug 517222. This is unrelated to this bug report.
There is an error dialog and another dialog open on the Mac test machine as seen in the screenshot -- http://download.eclipse.org/eclipse/downloads/drops4/I20170527-0800/testresults/ep47I-unit-mac64_macosx.cocoa.x86_64_8.0/org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Display.test_setCursorLocationII.png Opened Bug 517350 to close the open dialogs.
Just checked the test result pages of earlier milestones, these tests have been failing since M3. The test results for M1 & M2 are not available, so not sure if they passed then. Dani, is there another bug that tracks the test failures in the older milestones? I'm setting up the workspace to check if the tests pass locally.
(In reply to Lakshmi Shanmugam from comment #5) > Just checked the test result pages of earlier milestones, these tests have > been failing since M3. The test results for M1 & M2 are not available, so > not sure if they passed then. Dani, is there another bug that tracks the > test failures in the older milestones? I don't think so, but you can do a bugzilla search to verify that.
> > I'm setting up the workspace to check if the tests pass locally. The tests fail locally as well.
The tests pass locally on 4.6. I spent some time debugging the tests and compared the code flow in 4.6 vs 4.7. In HandlerServicehandler.isHandled(), HandlerServiceImpl retrieves different EclipseContext in both cases. Will continue further investigation for 4.8.
The HandlerActivationTests fail due to error dialogs created by the PartRenderingTests.test_persistState_371087_1(). They can't find the correct active Shell due to the error dialogs. Running test_persistState_371087_1() causes multiple error dialogs, but the test doesn't fail, so not sure if it expected. If I disable the test & run the UIAllTests, all the tests pass locally. I think for 4.7RC4 we could disable PartRenderingTests.test_persistState_371087_1() on Mac and open a separate bug to track this.
Created attachment 268778 [details] patch test_persistState_371087_1 creates error dialogs which causes HandlerActivationTests to fail on Mac. Disabled the test on Mac. I'm unable to create a gerrit patch, hence attached the patch here.
(In reply to Lakshmi Shanmugam from comment #10) > I'm unable to create a gerrit patch, hence attached the patch here. What's the problem?
New Gerrit change created: https://git.eclipse.org/r/98763
(In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/98763 I have uploaded the patch from comment #10 as a Gerrit patch. I was not able to upload the Gerrit patch for platform.ui with Lakshmi as the author as I am not a committer on the project. Hence, I have added her as a co-author. Reviewed the patch by code inspection that it disables the test.
New Gerrit change created: https://git.eclipse.org/r/98801
Gerrit change https://git.eclipse.org/r/98801 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1059b3f5d5f4ae71d617016ea437f4e00dd64837
Gerrit change https://git.eclipse.org/r/98763 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=53371b084441e27b425e1e29f6006da4c0f1b76b
Increased bundle version for Photon (4.8) with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1004999ee6de0c656c6a8de637a6b64c539e252a
Thanks Noopur for creating the gerrit patch. I tried multiple times to create the gerrit, but got insufficient permissions error.
(In reply to Lakshmi Shanmugam from comment #18) > Thanks Noopur for creating the gerrit patch. > I tried multiple times to create the gerrit, but got insufficient > permissions error. The author and committer must be entered as: Full name <e-mail> e.g. Dani Megert <Daniel_Megert@ch.ibm.com> and the e-mail is case-sensitive (check in your Gerrit account).
(In reply to Eclipse Genie from comment #15) > Gerrit change https://git.eclipse.org/r/98801 was merged to > [R4_7_maintenance]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1059b3f5d5f4ae71d617016ea437f4e00dd64837 > The e4.ui.tests passed in http://download.eclipse.org/eclipse/downloads/drops4/I20170607-2000/testResults.php
(In reply to Dani Megert from comment #20) > (In reply to Eclipse Genie from comment #15) > > Gerrit change https://git.eclipse.org/r/98801 was merged to > > [R4_7_maintenance]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1059b3f5d5f4ae71d617016ea437f4e00dd64837 > > > > The e4.ui.tests passed in > http://download.eclipse.org/eclipse/downloads/drops4/I20170607-2000/testResults.php > Looks like this was pure luck. Note that also other tests like bug 466636 fail again. I suspect something else is opening a dialog / stealing the focus.
After further investigation, found that the tests started failing due the changes made for this bug - https://bugs.eclipse.org/bugs/show_bug.cgi?id=499017. There are 4 tests in PartRenderingEngineTests that throw RuntimeException and cause error dialogs to be opened - testBug331795_1, testBug331795_2, test_persistState_371087, test_persistState_371087_1. The earlier patch disabled only test_persistState_371087_1 and that was enough for the tests to pass locally on my machine. Disabling the other 3 tests should prevent the failures on the test machine. But, I don't think that is the right solution.
New Gerrit change created: https://git.eclipse.org/r/101052
Gerrit change https://git.eclipse.org/r/101052 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c3471990234ccb4311d3d0dd593dda190e091df
Let's watch the tests for a while and then backport to 4.7.1.
(In reply to Dani Megert from comment #25) > Let's watch the tests for a while and then backport to 4.7.1. Looks like they all pass now on master.
New Gerrit change created: https://git.eclipse.org/r/101411
(In reply to Eclipse Genie from comment #27) > New Gerrit change created: https://git.eclipse.org/r/101411 Created gerrit patch for backporting to 4.7.1.
(In reply to Lakshmi Shanmugam from comment #28) > (In reply to Eclipse Genie from comment #27) > > New Gerrit change created: https://git.eclipse.org/r/101411 > > Created gerrit patch for backporting to 4.7.1. The tests have failed again in the M-build - M20170726-0400. Dani, can you please push the gerrit change for 4.7.1?
(In reply to Lakshmi Shanmugam from comment #29) > (In reply to Lakshmi Shanmugam from comment #28) > > (In reply to Eclipse Genie from comment #27) > > > New Gerrit change created: https://git.eclipse.org/r/101411 > > > > Created gerrit patch for backporting to 4.7.1. > > The tests have failed again in the M-build - M20170726-0400. Dani, can you > please push the gerrit change for 4.7.1? The tests have failed again in this week's M-build - M20170802-0400.
Gerrit change https://git.eclipse.org/r/101411 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b00e6cc721f56c61f104cf775c1ed25c48cf3a5c
(In reply to Eclipse Genie from comment #31) > Gerrit change https://git.eclipse.org/r/101411 was merged to > [R4_7_maintenance]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b00e6cc721f56c61f104cf775c1ed25c48cf3a5c > Updated bundle version with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=316e6141a4039b8303451211d459474be510f95b
