Bug 516715 - org.eclipse.ui.genericeditor.tests must not influence normal runtime workbench
Summary: org.eclipse.ui.genericeditor.tests must not influence normal runtime workbench
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.7 RC1   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2017-05-16 07:46 EDT by Markus Keller CLA
Modified: 2017-05-30 02:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2017-05-16 07:46:12 EDT 
A rule for sane test bundles is that they must not screw a normal runtime workbench. I.e. when you launch with the test bundle enabled, there should not be any visible damage. Until recently, Platform Text was in the "sane" category (unlike the horribly breaking Platform UI tests).

org.eclipse.ui.genericeditor.tests contributes an unconditional hover provider "MagicHoverProvider" that makes all generic editors in a runtime workbench show a hover with text "Alrighty!". This contribution needs to be disabled by default. It must only be enabled while the test that needs it is running.

Also make a pass over other globally contributed behavior and make sure it behaves.
Comment 1 Markus Keller CLA 2017-05-16 07:47:16 EDT 
Assigning to 4.8. Feel free to fix this in 4.7 up to RC3.
Comment 2 Mickael Istria CLA 2017-05-16 07:50:43 EDT 
I'll do it today, it should be hard as the generic editor extensions already allow filtering by content type.
Comment 3 Eclipse Genie CLA 2017-05-16 08:30:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/97222
Comment 5 Mickael Istria CLA 2017-05-16 08:43:02 EDT 
Thanks for the remind Markus.