Bug 516534 - Remove unnecessary dependency to org.eclipse.ui.tests.harness from org.eclipse.ui.genericeditor.tests
Summary: Remove unnecessary dependency to org.eclipse.ui.tests.harness from org.eclips...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.7 RC1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2017-05-11 16:02 EDT by Lars Vogel CLA
Modified: 2017-05-29 14:49 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-05-11 16:02:42 EDT 
org.eclipse.ui.tests.harness seems unused in org.eclipse.ui.genericeditor.tests.
Comment 1 Eclipse Genie CLA 2017-05-11 16:03:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/96891
Comment 2 Mickael Istria CLA 2017-05-12 01:39:38 EDT 
Actually, the issue is more that org.eclipse.ui.tests.harness DisplayHelper should be fixed and reused in the org.eclipse.ui.genericeditor.tests. See bug 513399
Comment 3 Lars Vogel CLA 2017-05-12 02:00:27 EDT 
(In reply to Mickael Istria from comment #2)
> Actually, the issue is more that org.eclipse.ui.tests.harness DisplayHelper
> should be fixed and reused in the org.eclipse.ui.genericeditor.tests. See
> bug 513399

If I understood Markus correctly, he does not want to depend on platform UI code in text. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=511101#c9
Comment 4 Dani Megert CLA 2017-05-12 04:20:59 EDT 
(In reply to Lars Vogel from comment #3)
> If I understood Markus correctly, he does not want to depend on platform UI
> code in text. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=511101#c9

+1 to that.
Comment 6 Mickael Istria CLA 2017-05-15 09:26:18 EDT 
Thanks Lars.
Comment 7 Lars Vogel CLA 2017-05-29 14:49:59 EDT 
commit looks fine.