Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #444840 +++ Bug 444840 has a fix for making IDE.getEditorId public. I have finally been able to upgrade to a version of Eclipse that I thought had this fix in it, and I could not find it anywhere. It turns out that the fix in Bug 444840 was undone accidentally, See Bug 460652 Comment 8. As there was never a release with the new API, there was never an API error. I would like to resubmit the fix in Bug 444840 for Oxygen.
I guess this is actually too late for 4.7. Can it go in 4.7.1, or does it need to now wait until 4.8?
(In reply to Jonah Graham from comment #1) > I guess this is actually too late for 4.7. Can it go in 4.7.1, or does it > need to now wait until 4.8? 4.7.1 is fine.
May be it would make sense this time to add some JUnit tests for the new API?
(In reply to Andrey Loskutov from comment #3) > May be it would make sense this time to add some JUnit tests for the new API? I would be happy to. I have -1'd the change until I do.
4.7.2 is coming soon.
Are you planning to do for M6?
(In reply to Sarika Sinha from comment #6) > Are you planning to do for M6? I don't think so. I don't know if/when I will ever get to this. If it can be accepted without new tests, then you can have it now.
I have now returned to this. Thank you for your patience. Tests written.
Gerrit change https://git.eclipse.org/r/96800 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=13aeb0acea830c808461c0ff4e8d55f43fb8183a
Should we have a note about it in the N&N?
(In reply to Eclipse Genie from comment #9) > Gerrit change https://git.eclipse.org/r/96800 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=13aeb0acea830c808461c0ff4e8d55f43fb8183a Thanks to this commit and thanks to commit 75e20618d3cef3a8b85b21f9e7cacded20798e1e that removed javadoc warnings, we see now an error in releng tests: https://download.eclipse.org/eclipse/downloads/drops4/I20190626-1800/testresults/html/org.eclipse.releng.tests_ep413I-unit-cen64-gtk3-java8_linux.gtk.x86_64_8.0.html#org.eclipse.releng.tests https://download.eclipse.org/eclipse/downloads/drops4/I20190626-1800/compilelogs/platform.doc.isv.javadoc.txt ../../../eclipse.platform.ui/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java:823: error: reference not found * <li>The preferred {@link IUnknownEditorStrategy} is consulted.</li> ^ 1 error I will revert commit 75e20618d3cef3a8b85b21f9e7cacded20798e1e and fix the javadoc warning about missing type.
New Gerrit change created: https://git.eclipse.org/r/144968
Gerrit change https://git.eclipse.org/r/144968 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=03b1cc2f31418f0ffe649ea5082b88d7eb85b215
(In reply to Andrey Loskutov from comment #11) > I will revert commit 75e20618d3cef3a8b85b21f9e7cacded20798e1e and fix the > javadoc warning about missing type. Thank you for identifying and fixing the new error that was exposed. Can this be marked fixed again?
(In reply to Jonah Graham from comment #14) > (In reply to Andrey Loskutov from comment #11) > > I will revert commit 75e20618d3cef3a8b85b21f9e7cacded20798e1e and fix the > > javadoc warning about missing type. > Thank you for identifying and fixing the new error that was exposed. > > Can this be marked fixed again? Sure, if the next build will be green again.
Tests are green again.
