Community
Participate
Working Groups
I20170425-2000 In my master workspace (with source for the complete Eclipse SDK) I had the Type Hierarchy view focused on java.lang.Object. Then I opened a compare editor from a recently pulled Git commit (JavaBasePreferencePage.java, from bug 515534). This froze the Eclipse UI for more than a minute. I'm appending a stacktrace taken during the freeze. The JavaEditor's calls to CompilationUnit#reconcile(*) in the UI thread are an old design issue, but that wasn't a blocker so far. A low-hanging fruit is that TypeHierarchy.getAllSubtypesForType0(IType, ArrayList<IType>) is horribly inefficient after "subs.contains(subType)" was added in bug 469668. Should probably use a TypeVector here. Bug 489966 has optimized that class for such use cases. at java.util.ArrayList.indexOf(ArrayList.java:316) at java.util.ArrayList.contains(ArrayList.java:300) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.getAllSubtypesForType0(TypeHierarchy.java:446) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.getAllSubtypesForType(TypeHierarchy.java:434) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.getAllSubtypes(TypeHierarchy.java:427) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.hasSubtypeNamed(TypeHierarchy.java:763) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.subtypesIncludeSupertypeOf(TypeHierarchy.java:1489) at org.eclipse.jdt.internal.core.hierarchy.ChangeCollector.addTypeAddition(ChangeCollector.java:252) at org.eclipse.jdt.internal.core.hierarchy.ChangeCollector.addChange(ChangeCollector.java:203) at org.eclipse.jdt.internal.core.hierarchy.ChangeCollector.addAffectedChildren(ChangeCollector.java:58) at org.eclipse.jdt.internal.core.hierarchy.ChangeCollector.addChange(ChangeCollector.java:92) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.isAffectedByOpenable(TypeHierarchy.java:1030) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.isAffected(TypeHierarchy.java:854) at org.eclipse.jdt.internal.core.hierarchy.TypeHierarchy.elementChanged(TypeHierarchy.java:347) at org.eclipse.jdt.internal.core.DeltaProcessor$3.run(DeltaProcessor.java:1703) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.jdt.internal.core.DeltaProcessor.notifyListeners(DeltaProcessor.java:1693) at org.eclipse.jdt.internal.core.DeltaProcessor.fireReconcileDelta(DeltaProcessor.java:1545) at org.eclipse.jdt.internal.core.DeltaProcessor.fire(DeltaProcessor.java:1504) at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:765) at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:790) at org.eclipse.jdt.internal.core.CompilationUnit.reconcile(CompilationUnit.java:1250) at org.eclipse.jdt.internal.core.CompilationUnit.reconcile(CompilationUnit.java:1211) at org.eclipse.jdt.internal.corext.util.JavaModelUtil.reconcile(JavaModelUtil.java:599) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider.createFakeCompiltationUnit(CompilationUnitDocumentProvider.java:1142) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider.createFakeCompiltationUnit(CompilationUnitDocumentProvider.java:1055) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider.connect(CompilationUnitDocumentProvider.java:1280) at org.eclipse.ui.texteditor.AbstractTextEditor.doSetInput(AbstractTextEditor.java:4178) at org.eclipse.ui.texteditor.StatusTextEditor.doSetInput(StatusTextEditor.java:257) at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.doSetInput(AbstractDecoratedTextEditor.java:1466) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.internalDoSetInput(JavaEditor.java:2557) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.doSetInput(JavaEditor.java:2544) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.doSetInput(CompilationUnitEditor.java:1417) at org.eclipse.jdt.internal.ui.compare.JavaMergeViewer$CompilationUnitEditorAdapter.doSetInput(JavaMergeViewer.java:614) at org.eclipse.ui.texteditor.AbstractTextEditor$5.run(AbstractTextEditor.java:3154) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:437) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:353) at org.eclipse.ui.internal.WorkbenchWindow$14.run(WorkbenchWindow.java:2195) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70) at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2191) at org.eclipse.ui.texteditor.AbstractTextEditor.internalInit(AbstractTextEditor.java:3172) at org.eclipse.ui.texteditor.AbstractTextEditor.init(AbstractTextEditor.java:3197) at org.eclipse.jdt.internal.ui.compare.JavaMergeViewer.getSourceViewerConfiguration(JavaMergeViewer.java:276) at org.eclipse.jdt.internal.ui.compare.JavaMergeViewer.configureTextViewer(JavaMergeViewer.java:215) at org.eclipse.compare.contentmergeviewer.TextMergeViewer.configureSourceViewer(TextMergeViewer.java:3080) at org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateContent(TextMergeViewer.java:3028) at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.internalRefresh(ContentMergeViewer.java:802) at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.inputChanged(ContentMergeViewer.java:710) at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:286) at org.eclipse.jdt.internal.ui.compare.JavaMergeViewer.setInput(JavaMergeViewer.java:152) at org.eclipse.compare.CompareViewerSwitchingPane.setInput(CompareViewerSwitchingPane.java:270) at org.eclipse.compare.internal.CompareContentViewerSwitchingPane.setInput(CompareContentViewerSwitchingPane.java:192) at org.eclipse.compare.CompareEditorInput.internalSetContentPaneInput(CompareEditorInput.java:855) at org.eclipse.compare.CompareEditorInput.access$7(CompareEditorInput.java:853) at org.eclipse.compare.CompareEditorInput$10.run(CompareEditorInput.java:786) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70) at org.eclipse.compare.CompareEditorInput.feed1(CompareEditorInput.java:779) at org.eclipse.compare.CompareEditorInput.feedInput(CompareEditorInput.java:757) at org.eclipse.compare.CompareEditorInput.createContents(CompareEditorInput.java:553) at org.eclipse.compare.internal.CompareEditor.createCompareControl(CompareEditor.java:444) at org.eclipse.compare.internal.CompareEditor.access$6(CompareEditor.java:404) at org.eclipse.compare.internal.CompareEditor$1$1.run(CompareEditor.java:361) at org.eclipse.ui.internal.PendingSyncExec.run(PendingSyncExec.java:58) at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:168) at org.eclipse.ui.internal.UISynchronizer.lambda$0(UISynchronizer.java:150) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:37) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4213) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3820) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1146) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1035) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153) at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590) at org.eclipse.equinox.launcher.Main.run(Main.java:1499) at org.eclipse.equinox.launcher.Main.main(Main.java:1472)
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
*** This bug has been marked as a duplicate of bug 568937 ***
