Bug 515663 - "Import projects" : top level folder imported as a Java project referencing src folder to child project
Summary: "Import projects" : top level folder imported as a Java project referencing s...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.7 M7   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-24 05:34 EDT by Aurelien Pupier CLA
Modified: 2017-04-26 13:32 EDT (History)
2 users (show)

See Also:

Attachments
more visual way to understand the issue (130.14 KB, image/png)
2017-04-24 05:34 EDT, Aurelien Pupier CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aurelien Pupier CLA 2017-04-24 05:34:48 EDT 
Created attachment 267933 [details]
more visual way to understand the issue

using Eclipse DSL Tools

Version: Oxygen Release Milestone 6 (4.7.0 M6)
Build id: 20170316-1528


I cloned the MAT gerrit repo https://git.eclipse.org/r/#/admin/projects/mat/org.eclipse.mat
then click "Import projects"

I ended with the top level folder imported as a Java project which have src folders defined pointing to chidren src folder.
Comment 1 Andrey Loskutov CLA 2017-04-24 09:44:07 EDT 

*** This bug has been marked as a duplicate of bug 515590 ***
Comment 2 Aurelien Pupier CLA 2017-04-24 09:51:17 EDT 
I don't think that it is a duplicate.
The issu here, is that the top-level project is imported as a Java one but from my point of view it should be imported as a general project (or a maven project if there is pom.xml)
Comment 3 Mickael Istria CLA 2017-04-24 09:56:57 EDT 
@Aurelien: does the Eclipse DSL Tools contain m2e ? If there is no m2e, then it's not even aware of the meaning of a pom.xml so it cannot take a good decision.
Comment 4 Aurelien Pupier CLA 2017-04-25 12:42:53 EDT 
(In reply to Mickael Istria from comment #3)
> @Aurelien: does the Eclipse DSL Tools contain m2e ? If there is no m2e, then
> it's not even aware of the meaning of a pom.xml so it cannot take a good
> decision.

m2e is part of Eclipse DSL
Comment 5 Mickael Istria CLA 2017-04-25 12:48:52 EDT 
I tried it and it seems MAT gets configured as a JavaScript project. Is this what you see too?
Comment 6 Aurelien Pupier CLA 2017-04-25 12:52:06 EDT 
(In reply to Mickael Istria from comment #5)
> I tried it and it seems MAT gets configured as a JavaScript project. Is this
> what you see too?

no, it was configured as a pure Java project
Comment 7 Mickael Istria CLA 2017-04-26 05:58:24 EDT 
This is definitely a bug in the orchestrating SmartImportJob. It's not supposed to recurse into folders that are already known to be Eclipse projects. I'm working on this with a unit test to reproduce the issue and avoid regressions.
Comment 8 Eclipse Genie CLA 2017-04-26 09:28:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/95798
Comment 10 Eclipse Genie CLA 2017-04-26 10:17:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/95808