Bug 515460 - [Dark Theme] use CTabFolder in Installation Details dialog to avoid white tabs
Summary: [Dark Theme] use CTabFolder in Installation Details dialog to avoid white tabs
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.9   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Denis Ungemach CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2017-04-19 10:31 EDT by Lars Vogel CLA
Modified: 2018-09-13 01:28 EDT (History)
5 users (show)

See Also:

Attachments
Screenshot (61.91 KB, image/png)
2017-06-09 03:54 EDT, Lars Vogel CLA 		no flags Details
On Mac it looks good (219.15 KB, image/png)
2017-06-09 05:44 EDT, Matthias Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-04-19 10:31:16 EDT 
InstallationDialog should use CTabFolder instead of TabFolder to allow styling in the dark theme.
Comment 1 Lars Vogel CLA 2017-04-19 10:31:33 EDT 
Patrik, something for you?
Comment 2 Lars Vogel CLA 2017-06-09 03:54:06 EDT 
Created attachment 268834 [details]
Screenshot

Matthias, could you provide a Gerrit? Repo is equinox.p2, class is 
InstallationDialog. You would need to replace TabFolder and TabItem with CTabFolder and CTabItem.
Comment 3 Matthias Becker CLA 2017-06-09 05:44:02 EDT 
Created attachment 268842 [details]
On Mac it looks good

On Mac the installation details dialog on oxygen looks good in the dark theme.
Comment 4 Lars Vogel CLA 2017-06-09 06:17:50 EDT 
(In reply to Matthias Becker from comment #3)
> Created attachment 268842 [details]
> On Mac it looks good
> 
> On Mac the installation details dialog on oxygen looks good in the dark
> theme.

Do you have access to Linux or Windows? TabFolder on Mac looks OK, on Linux not, on Windows I do not know.
Comment 5 Alexander Kurtakov CLA 2018-03-08 02:08:54 EST 
Lars, is this still an issue with recent SWT? For the record I'm against using CTabFolder as it's custom draws is pretty bad IMHO. We should better fix SWT.
Comment 6 Lars Vogel CLA 2018-03-08 03:25:25 EST 
(In reply to Alexander Kurtakov from comment #5)
> Lars, is this still an issue with recent SWT? For the record I'm against
> using CTabFolder as it's custom draws is pretty bad IMHO. We should better
> fix SWT.

As long as TabFolder does not allow setting the tab color we need to use CTabFolder. Do you have plans to enhance TabFolder?
Comment 7 Lars Vogel CLA 2018-04-23 08:08:40 EDT 
(In reply to Lars Vogel from comment #6)
> (In reply to Alexander Kurtakov from comment #5)
> Do you have plans to enhance TabFolder? If not, we should move to CTabFolder to enhance the dark theme under Windows/Mac and Ubuntu.
Comment 8 Thomas Watson CLA 2018-09-04 11:00:04 EDT 
Dropping milestone.
Comment 9 Eclipse Genie CLA 2018-09-12 12:05:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/129251
Comment 11 Matthias Becker CLA 2018-09-13 01:28:34 EDT 
Thank you Denis for the fix