Bug 515146 - Problems view icon doesn't show errors/warnings overlay after startup
Summary: Problems view icon doesn't show errors/warnings overlay after startup
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 4.7 RC1   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, noteworthy
Depends on:
Blocks:
 
Reported: 2017-04-12 02:32 EDT by Markus Keller CLA
Modified: 2017-05-18 09:56 EDT (History)
3 users (show)

See Also:
daniel_megert: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2017-04-12 02:32:01 EDT 
I20170411-0500

The Problems view icon doesn't show errors/warnings overlays any more after startup, unless the Problems view is on top of the view stack.

This is a regression that is at most a few weeks old.
Comment 1 Lars Vogel CLA 2017-04-12 02:44:39 EDT 
See Bug 513901.
Comment 2 Andrey Loskutov CLA 2017-04-12 03:01:09 EDT 
Please see discussion on bug 513901. The default behavior was changed, but functionality is still there. To restore the previous behavior, one can use General -> Startup and Shutdown -> Show Problems view decorations on startup.
Comment 3 Markus Keller CLA 2017-05-10 12:30:47 EDT 
This regression at least needs to be documented in the N&N.

Furthermore, the preference page needs the keyword "problems"
Comment 4 Eclipse Genie CLA 2017-05-11 04:01:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/96787
Comment 5 Eclipse Genie CLA 2017-05-11 04:24:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/96789
Comment 6 Andrey Loskutov CLA 2017-05-11 04:40:55 EDT 
(In reply to Markus Keller from comment #3)
> This regression at least needs to be documented in the N&N.

See https://git.eclipse.org/r/96789. I have no rights to merge it, so please check if it is OK and merge.

> Furthermore, the preference page needs the keyword "problems"

Markus, you've set this target to M7, but as far as I understood we should not merge into M7 anymore.

The fix https://git.eclipse.org/r/96787 is there, I've checked that the preference "problems" keyword shows now the startup page too, so please merge the patch if you think it should be in M7.
Comment 7 Eclipse Genie CLA 2017-05-11 05:21:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/96797
Comment 9 Andrey Loskutov CLA 2017-05-12 10:35:00 EDT 
https://git.eclipse.org/r/#/c/96787/ is not merged yet, set  to RC1
Comment 11 Andrey Loskutov CLA 2017-05-14 12:29:36 EDT 
Dani, You have merged the fix to RC1 but didn't set the review flag. Can you please add your "+"? Thanks.
Comment 12 Dani Megert CLA 2017-05-14 12:35:51 EDT 
(In reply to Andrey Loskutov from comment #11)
> Dani, You have merged the fix to RC1 but didn't set the review flag. Can you
> please add your "+"? Thanks.

Thanks, for the reminder!
Comment 13 Dani Megert CLA 2017-05-15 04:14:30 EDT 
Verified with eclipse-SDK-I20170514-2000-win32-x86_64.
Comment 14 Markus Keller CLA 2017-05-18 09:56:39 EDT 
Fixed various issues in the N&N with http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=2bcf0193561299a6ef8cd573adac88f3fcf98fc2 and parent commit.