Bug 515018 - Save of edited files should always update the text search result and not only on delete
Summary: Save of edited files should always update the text search result and not only...
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 06:05 EDT by Lars Vogel CLA
Modified: 2019-09-25 10:55 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-04-10 06:05:59 EDT
I frequently use text search to identify something which I want to edit.

Unfortunately the search result does not update after I changed a file.

Would be create if the Search view updates the search result based on the edited files.
Comment 1 Dani Megert CLA 2017-04-10 06:24:59 EDT
Are you talking about updating after save or after typing? Both can become expensive.

Personally I like that the search result is static and I can refresh on demand.

Note that if we'd start to refresh the view, we would also have to refresh it when files are added or changed, e.g. when fetching from Git.
Comment 2 Lars Vogel CLA 2017-04-10 06:43:36 EDT
(In reply to Dani Megert from comment #1)
> Are you talking about updating after save or after typing? Both can become
> expensive.

After save.
Comment 3 Dani Megert CLA 2017-04-10 10:07:33 EDT
I am clearly -2 for such a change.
Comment 4 Lars Vogel CLA 2017-04-10 10:11:00 EDT
(In reply to Dani Megert from comment #3)
> I am clearly -2 for such a change.

Lets mark this as wontfix for now, I anyway to not have the time to work on this at the moment.
Comment 5 Lars Vogel CLA 2019-09-25 10:24:07 EDT
The search already updates itself, if you delete the line that contains the result and after. 

So not updating the search view if the entry has changed is inconsistent.
Comment 6 Nitin Dahyabhai CLA 2019-09-25 10:41:47 EDT
Handling on delete is a byproduct of the file/marker itself being removed, isn't it?
Comment 7 Lars Vogel CLA 2019-09-25 10:55:40 EDT
(In reply to Nitin Dahyabhai from comment #6)
> Handling on delete is a byproduct of the file/marker itself being removed,
> isn't it?

Maybe, still inconsistent behaviour at the moment