Bug 514848 - Make ElementDifferencer more flexible for subclasses
Summary: Make ElementDifferencer more flexible for subclasses
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.7   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2017-04-06 08:12 EDT by Vladimir Piskarev CLA
Modified: 2017-04-06 08:39 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2017-04-06 08:12:03 EDT 
Similarly to bug 514798, we'll introduce new methods in ElementDifferencer to make it more powerful as a base class.
Comment 1 Vladimir Piskarev CLA 2017-04-06 08:39:32 EDT 
Pushed to master:

http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=f5bb1435f85b8eeccb872bc8b92432c1eb3ceb27


Breaking changes:

* NOTE: I've changed the order of arguments newBody and oldBody in ElementDifferencer#findContentChange method to match one in JavaElementDeltaBuilder (and, hence, many legacy implementations). Since both arguments are of type Object, the method's signature has not changed, but the contract compatibility is clearly broken. Fortunately, there is little chance that any of the existing Handly-based implementations have overridden this method.

* ElementDifferencer#getDelta() now returns ElementDelta rather than IElementDelta (although this change is source compatible, binary compatibility is broken).