Bug 514798 - Make ElementDelta more flexible for subclasses
Summary: Make ElementDelta more flexible for subclasses
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.7   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2017-04-05 14:33 EDT by Vladimir Piskarev CLA
Modified: 2017-04-05 14:56 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2017-04-05 14:33:00 EDT 
Presently, we provide ElementDelta.Builder as the sole means for creating a delta tree. We'll introduce a number of "low-level mutator" methods in ElementDelta to make it possible for subclasses to efficiently implement an alternative API for building the delta tree. These methods can also serve as overridable "hooks" that allow subclasses to monitor and affect the delta tree as it is being built.
Comment 1 Vladimir Piskarev CLA 2017-04-05 14:56:53 EDT 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=fd720380e7efbc21a5f52c1360613ecf294cacaf

Breaking change:
ElementDelta.Builder#insert method is now private (was protected); it has been effectively replaced with new API: ElementDelta#hInsert.