Community
Participate
Working Groups
For Oxygen I have already ported the platform help bundles to Lucene 6.1.0. It would be nice if also other projects upgrade. To make this easier I already have prepared a gerrit patch which contains the necessary changes. The code changes are as least invasive as possible. I tested exhaustively manually, including case with older indexes, and did not see any issue. Also I made sure that all tests in org.eclipse.mylyn.tasks.index.tests pass. Gerrit follows.
New Gerrit change created: https://git.eclipse.org/r/92726
*** Bug 465966 has been marked as a duplicate of this bug. ***
Thanks for the contribution! We will need to file a piggyback CQ for this, won't we?
(In reply to comment #3) > Thanks for the contribution! We will need to file a piggyback CQ for this, won't > we? Yes, piggyback CQ is due.
(In reply to Sam Davis from comment #3) > Thanks for the contribution! You're welcome. I'll also stick around to potentially refine it until it's merged. > We will need to file a piggyback CQ for this, > won't we? Yes but it should be quite quick so the earlier the better.
Thanks. I don't think it's important to get this into 3.22, which releases April 7, but we should do this for 3.23, which will be our contribution to Oxygen.
(In reply to comment #6) > Thanks. I don't think it's important to get this into 3.22, which releases April > 7, but we should do this for 3.23, which will be our contribution to Oxygen. Sam, would you please file the piggyback CQ so it can go right after 3.22 is released to have more time for testing vs Oxygen.
Done: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12878
And also: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12879 (queryparser) https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12880 (analyzers-common)
All 3 CQs were approved.
Anything I can do at this point to move this forward?
Sorry, I haven't had a chance to look at this yet, but hopefully next week we'll get to it.
(In reply to Sam Davis from comment #12) > Sorry, I haven't had a chance to look at this yet, but hopefully next week > we'll get to it. Ping.
It would be extremely bad if Mylyn project doesn't have the capacity to sync with platform changes especially when a patch was even prepared. Is this still planned for Oxygen?
Yes, it's still planned. I have commented on the review. Sorry for the long delay. We didn't forget about this.
Gerrit change https://git.eclipse.org/r/92726 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=293e9929537bc7b33959eee01e29d6543c12f7a8
Thanks very much for the contribution!
I get the following 6 errors after I update my master branch. Description Resource Path Location Type Bundle 'org.apache.lucene.queryparser' cannot be resolved MANIFEST.MF /org.eclipse.mylyn.tasks.index.core/META-INF line 11 Plug-in Problem ParseException cannot be resolved to a type TaskListIndex.java /org.eclipse.mylyn.tasks.index.core/src/org/eclipse/mylyn/internal/tasks/index/core line 707 Java Problem QueryParser cannot be resolved to a type TaskListIndex.java /org.eclipse.mylyn.tasks.index.core/src/org/eclipse/mylyn/internal/tasks/index/core line 703 Java Problem QueryParser cannot be resolved to a type TaskListIndex.java /org.eclipse.mylyn.tasks.index.core/src/org/eclipse/mylyn/internal/tasks/index/core line 703 Java Problem The import org.apache.lucene.queryparser cannot be resolved TaskListIndex.java /org.eclipse.mylyn.tasks.index.core/src/org/eclipse/mylyn/internal/tasks/index/core line 51 Java Problem The import org.apache.lucene.queryparser cannot be resolved TaskListIndex.java /org.eclipse.mylyn.tasks.index.core/src/org/eclipse/mylyn/internal/tasks/index/core line 52 Java Problem
I use the OOMPH setup Maybe we need to add <import plugin="org.apache.lucene.queryparser" version="6.0.0" match="greaterOrEqual"/> in /org.eclipse.mylyn-feature/feature.xml Thoughts?
(In reply to Frank Becker from comment #19) > I use the OOMPH setup > > Maybe we need to add > > <import plugin="org.apache.lucene.queryparser" version="6.0.0" > match="greaterOrEqual"/> > > in /org.eclipse.mylyn-feature/feature.xml > > Thoughts? With review https://git.eclipse.org/r/#/c/96983/ we do no longer get the errors!
