Bug 513405 - Add JUnits and fix Javadocs of new APIs Table#setHeaderForeground/Background() et al.
Summary: Add JUnits and fix Javadocs of new APIs Table#setHeaderForeground/Background(...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 M7   Edit
Assignee: Conrad Groth CLA
QA Contact: Niraj Modi CLA
URL:
Whiteboard:
Keywords:
Depends on: 63038
Blocks: 384906 510728 514337
  Show dependency tree
 
Reported: 2017-03-09 14:14 EST by Markus Keller CLA
Modified: 2017-03-31 08:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2017-03-09 14:14:43 EST 
Follow-up to bug 384906.

Javadoc of new methods need fixes:

Table#setHeaderForeground(Color):
>  * Note: This is custom paint operation and only Windows table header foreground can be changed.

- Use correct sentences ("This is *a* ...").
- Only Windows? Looks like there's a GTK implementation, so it should use the same wording as setHeaderBackground(..).
- "custom paint" is not normally used in SWT API docs. The standard expression that should be used is:
     * Note: This operation is a hint and is not supported on all platforms.
- Proof-read the rest of the Javadocs (e.g. "look an feel")
Comment 1 Niraj Modi CLA 2017-03-15 04:21:33 EDT 
Hi Conrad/Lars,
Apart for JavaDoc fixes, we will also need JUnit test for the new Table header APIs. Thanks
Comment 2 Conrad Groth CLA 2017-03-17 17:03:07 EDT 
The tests can be found in the linked gerrit change 91822.
The JavaDoc was fixed in the gerrit change for bug 510728.
Comment 3 Niraj Modi CLA 2017-03-31 08:05:40 EDT 
JavaDoc changes got resolved as part of below commit:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d1079d72b176966ee4a60ab951c7687ce3123562

JUnits got added as part of below commit:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0311cc0637c61d3d24e0d166c4c80fa4679b51cf

Resolving this bug now.