Bug 513321 - [Generic Editor] Show an "aggregated" hover when multiple hover are contributed
Summary: [Generic Editor] Show an "aggregated" hover when multiple hover are contributed
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M2   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2017-03-08 10:47 EST by Mickael Istria CLA
Modified: 2017-09-09 15:21 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-03-08 10:47:44 EST 

    


    


      



        
          Comment 1
        

        
          Mickael Istria CLA

        

        
        

        
          2017-03-08 10:49:48 EST
        

      






Currently, when multiple contribution do contribute a hover at a given position, only the first one (priority order defined in extension) is shown. It would be very nice instead to show an aggregation of those hovers.

    


    


      



        
          Comment 2
        

        
          Mickael Istria CLA

        

        
        

        
          2017-03-08 11:04:43 EST
        

      






The difficulty here is that not all hover are text or HTML, for example Debug hover is a Tree, and hover can specify their control creator and receive different input. I believe this can be implemented, but wouldn't be easy.

    


    


      



        
          Comment 3
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-07-20 11:35:37 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/100354

    


    

    


      



        
          Comment 5
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-09-08 06:04:44 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/104727

    


    

    


      



        
          Comment 7
        

        
          Mickael Istria CLA

        

        
        

        
          2017-09-08 06:08:49 EDT
        

      






(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/104727 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/
> ?id=c40615d48f10a760873dd7857883fac588438d39

An API issue got merged, so I reverted the change and will provide a full patch set which include initial patch + API fix.

    


    


      



        
          Comment 8
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-09-08 06:16:12 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/104728

    


    


      



        
          Comment 9
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-09-08 06:20:56 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/104731

    


    

    


      



        
          Comment 11
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-09-08 11:18:36 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/104765