Bug 51324 - [CoolBar] [JFace] ApplicationWindow.createCoolBar tests coolBarManager 2x
Summary: [CoolBar] [JFace] ApplicationWindow.createCoolBar tests coolBarManager 2x
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2004-02-08 00:25 EST by Rob Warner CLA
Modified: 2009-08-30 02:10 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Warner CLA 2004-02-08 00:25:16 EST
In ApplicationWindow, the createCoolBar method tests coolBarManager 2x, and
doesn't test toolBarManager:

if ((getShell() == null) && (coolBarManager == null) && (coolBarManager == null)) {

(Line 255)

This is the case in 3.0 M6, as well as N20040207. Both win32.

The effect of this is that if you call addToolBar(), then addCoolBar(), you get
both toolbar and coolbar, though the documentation says you get one or the
other. If you call addCoolBar(), then addToolBar(), only the coolbar gets created.

Obviously, the code should read:

if ((getShell() == null) && (toolBarManager == null) && (coolBarManager == null)) {
Comment 1 Eric Moffatt CLA 2006-06-23 15:57:46 EDT
Cleaning up defect lists by setting ones without recent traffic to 'REMIND'.
Comment 2 Denis Roy CLA 2009-08-30 02:10:23 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.