513115 – GTK: MenuDetect issues with toolbar

Bug 513115 - GTK: MenuDetect issues with toolbar

Summary: GTK: MenuDetect issues with toolbar

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.7
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Alexander Kurtakov
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:	527860
Blocks:
	Show dependency tree

Reported:	2017-03-05 08:45 EST by Thomas Singer
Modified:	2018-04-12 14:32 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Code sample (1.36 KB, text/plain) 2017-03-05 08:46 EST, Thomas Singer	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Singer

2017-03-05 08:45:51 EST

Please launch the attached sample code. When right-clicking the toolbar right beside "Long Item", "Menu detected" will be printed on the console - fine. Right-clicking on a toolbar button causes "Menu detected" to be printed 2 times - bad. Right-clicking on the separator causes no "Menu detected" to be printed - bad.

Comment 1 Thomas Singer

2017-03-05 08:46:14 EST

Created attachment 267109 [details]
Code sample

Comment 2 Eclipse Genie

2017-03-21 08:32:31 EDT

New Gerrit change created: https://git.eclipse.org/r/93503

Comment 3 Eclipse Genie

2017-03-21 08:48:46 EDT

Gerrit change https://git.eclipse.org/r/93503 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8bd9620059daff78087c993d22fdbe714fe2d2ac

Comment 4 Alexander Kurtakov

2017-03-21 08:49:18 EDT

(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/93503 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=8bd9620059daff78087c993d22fdbe714fe2d2ac

Double "Menu detected" fixed. Separator issue needs more investigating.

Comment 5 Andrey Loskutov

2017-11-28 11:32:59 EST

@Thomas: was this issue a *regression* in 4.7, or was this always like this on GTK3 SWT?

I'm asking to understand better if the partial fix can be reverted, because it caused a severe regression in bug 527860.

Comment 6 Thomas Singer

2017-11-28 11:40:23 EST

(In reply to Andrey Loskutov from comment #5)
> @Thomas: was this issue a *regression* in 4.7, or was this always like this
> on GTK3 SWT?

I don't know, because of the large number of GTK3 problems we did not use it a long time. Because the multiple issues with the GTK toolbar we wrote our own self-painted one for SmartGit.

Comment 7 Eclipse Genie

2017-11-28 13:45:07 EST

New Gerrit change created: https://git.eclipse.org/r/112484

Comment 8 Eclipse Genie

2017-11-28 14:26:00 EST

Gerrit change https://git.eclipse.org/r/112484 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=056a3d562f2f340d63370d8408fc17e81209a712

Comment 9 Eclipse Genie

2017-11-28 16:25:31 EST

New Gerrit change created: https://git.eclipse.org/r/112512

Comment 10 Alexander Kurtakov

2017-11-29 03:22:41 EST

Thomas, can you create a junit test for this issue? We need these issues catched by tests as otherwise there is always smth to miss.

Comment 11 Eclipse Genie

2017-11-29 05:00:19 EST

Gerrit change https://git.eclipse.org/r/112512 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5a6656cb7a403b102a129c5017dc01e479e1ccda

Comment 12 Eclipse Genie

2017-11-29 05:00:23 EST

Gerrit change https://git.eclipse.org/r/112512 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5a6656cb7a403b102a129c5017dc01e479e1ccda

Comment 13 Eric Williams

2018-03-28 11:00:44 EDT

Is there anything left to be done here?