Bug 512581 - Menu doesn't show (any) keybinding for commands which have multiple shortcuts
Summary: Menu doesn't show (any) keybinding for commands which have multiple shortcuts
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-22 12:48 EST by Mickael Istria CLA
Modified: 2020-07-22 00:38 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2017-02-22 12:48:05 EST
I'm trying to add a menu for "Zoom In" in the IDE. "Zoom In" is bound to both Ctrl+ and Ctrl= (like Firefox or other common software). However, once added to a menu, the "Zoom In" entry doesn't show any shortcut like other commands have.

Other commands do properly show the shortcut on the right of the menu entry.
Comment 1 Patrik Suzzi CLA 2017-02-22 13:21:16 EST
If you think it is because of multiple shortcuts, we should agree on a tactic to display at least one shortcut, which can be either:
- display one single shortcut. In this case we need an ordering criteria
- display all shortcuts, comma-separated.
Comment 2 Mickael Istria CLA 2017-02-22 14:18:56 EST
(In reply to Patrik Suzzi from comment #1)
> If you think it is because of multiple shortcuts

Yes, I think so because Zoom In (with 2 shortcuts) shows no shortcut in menu whereas Zoom Out (with 1 shortcut) shows it.

> we should agree on a
> tactic to display at least one shortcut, which can be either:
> - display one single shortcut. In this case we need an ordering criteria
> - display all shortcuts, comma-separated.

I think that showing any of them, whichever - even if it's random-, is better than showing nothing. So a possible strategy is simply to return the 1st binding of the list as it's received by the API.
Comment 3 Eclipse Genie CLA 2020-07-21 14:45:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Mickael Istria CLA 2020-07-22 00:38:34 EDT
Still relevant