Community
Participate
Working Groups
When using the direct editor for a state in a state-machine diagram, either directly after creating the state, or selecting the state in the diagram and pressing F2, and pressing the enter key to finish editing the name, moves the cursor to the next line and does not finish the editing as expected. Steps to reproduce: 1) Create a UML-RT model based on the "UML-RT for C++" template 2) Create a capsule 3) Create a state-machine for the capsule 4) Open the state-machine diagram 5) Add a new state using the state tool from the palette 6) The direct editor is not activated 7) Start typing a new name and press enter 8) The edit box is now increased with a new line and the cursor is placed on the new line Expected result would have been to simply finish the naming of the state, similar to how it is done for choice point and other pseudo-states.
(In reply to Peter Cigehn from comment #0) > When using the direct editor for a state in a state-machine diagram, either > directly after creating the state, or selecting the state in the diagram and > pressing F2, and pressing the enter key to finish editing the name, moves > the cursor to the next line and does not finish the editing as expected. > > Steps to reproduce: > > 1) Create a UML-RT model based on the "UML-RT for C++" template > 2) Create a capsule > 3) Create a state-machine for the capsule > 4) Open the state-machine diagram > 5) Add a new state using the state tool from the palette > 6) The direct editor is not activated > 7) Start typing a new name and press enter > 8) The edit box is now increased with a new line and the cursor is placed on > the new line > > Expected result would have been to simply finish the naming of the state, > similar to how it is done for choice point and other pseudo-states. This is almost the same behaviour as in base Papyrus. in step 6, above, the direct editor is activated in Papyrus. Should it be pushed to Papyrus as a more desirable approach (potentially breaking workflow for established Papyrus users) or should it be solved in Papyrus-RT?
(In reply to Charles Rivet from comment #1) > This is almost the same behaviour as in base Papyrus. in step 6, above, the > direct editor is activated in Papyrus. Sorry for the confusion. But I made a small, but very crucial, spelling error in step 6. It should of course be: 6. The direct editor is now activated Otherwise you are not able to start typing a name in step 7. So I expect the behavior and steps to be rather identical between Papyrus-RT and Papyrus. > Should it be pushed to Papyrus as a more desirable approach (potentially > breaking workflow for established Papyrus users) or should it be solved in > Papyrus-RT? Not sure if we need to do that. We have "overridden" several of the direct editors, using the extension mechanism that Papyrus provides for this, for several other model elements (ports, capsule parts, transitions and so on), so I think that we could simply do the same for states as well and keep this change local to Papyrus-RT. The only aspect is if we have similar issues were Papyrus for some reason have made it not possible to override the default direct editor (some priority issue I think). If I understood it correctly we have had some issues with this related to Bug 513060 for example, where some workaround had to be made (which now is tracked for reverting via Bug 513695). I suggest that we assume that we can fix this locally in Papyrus-RT by introducing the same simple (single-line) name editor as we have done for several other elements in Papyrus-RT. Only if we bump into issues, we push for a fix in Papyrus (similar to as what had to be done for Bug 513060).
Since no one is assigned, I move this one back to NEW to make that clear.
Young-Soo to investigate and implement simple solution is possible. Else document workaround in release note and address in a future release.
New Gerrit change created: https://git.eclipse.org/r/98251
Gerrit change https://git.eclipse.org/r/98251 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=a60e0d6ba391f967af7c2da4cdeeae598d02a1b5
Verified to be fixed in the latest Papyrus-RT build (#373). The direct editor for a state now finish when pressing enter as expected, making it easier/faster to enter a name for a new state.
Closing as verified fixed.
Hello This introduce regression for direct editor for RT Port. The gerrit is not supposed to change the direct editor of Port. I tested the port direct editor typed by a system protocol and I got the validation marker again: the xtext editor is used instead of the UML RT editor can some one else test if it works for ports ? Thanks
(In reply to smaoui asma from comment #9) > Hello > > This introduce regression for direct editor for RT Port. The gerrit is not > supposed to change the direct editor of Port. > I tested the port direct editor typed by a system protocol and I got the > validation marker again: the xtext editor is used instead of the UML RT > editor > > can some one else test if it works for ports ? > > Thanks Hi Asma, I will check it and let you know.
(In reply to smaoui asma from comment #9) > This introduce regression for direct editor for RT Port. The gerrit is not > supposed to change the direct editor of Port. > I tested the port direct editor typed by a system protocol and I got the > validation marker again: the xtext editor is used instead of the UML RT > editor > > can some one else test if it works for ports ? I tested this in the latest nightly build, and I cannot see this issue. I can create port based on a system protocol, and I don't get the error marker as you used to. From what I can see, the direct editor for a port is the plain name based one (it only shows the name of the port when editing, and not the "name : type" style as the more advanced editor from base Papyrus does. Were have you made you test? In a developer run-time workbench, or with the tester setup?
(In reply to Peter Cigehn from comment #11) > (In reply to smaoui asma from comment #9) > > This introduce regression for direct editor for RT Port. The gerrit is not > > supposed to change the direct editor of Port. > > I tested the port direct editor typed by a system protocol and I got the > > validation marker again: the xtext editor is used instead of the UML RT > > editor > > > > can some one else test if it works for ports ? > > I tested this in the latest nightly build, and I cannot see this issue. I > can create port based on a system protocol, and I don't get the error marker > as you used to. From what I can see, the direct editor for a port is the > plain name based one (it only shows the name of the port when editing, and > not the "name : type" style as the more advanced editor from base Papyrus > does. > > Were have you made you test? In a developer run-time workbench, or with the > tester setup? One thing that I know from experience is that things does not work out very well in existing workspaces. I usually create a new workspace to avoid any issues with old .metadata in the workspace. If I remember correctly, I think that I have exactly these kinds of issues with direct editors not working as expected when I tested in an old existing workspace, but which started to work as expected in a new fresh workspace...
(In reply to smaoui asma from comment #9) > Hello > > This introduce regression for direct editor for RT Port. The gerrit is not > supposed to change the direct editor of Port. > I tested the port direct editor typed by a system protocol and I got the > validation marker again: the xtext editor is used instead of the UML RT > editor > > can some one else test if it works for ports ? > > Thanks Asma, I changed port direct editor priority from highest to high because I don't think we need to set it to highest. However I don't think this does change anything since no other editor has higher priority than the medium priority. As Peter says there is possibility that your existing workspace remembers the preference setting for direct editor. See bug#517549. If you ever changed default direct editor then you have no way to get the default editor back due to this bug. To fix this manually, you need to open .metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.papyrus.extensionpoints.editors.prefs file and remove the entry for the port direct editor and restart the workbench. If you are using Oomph preference recorder then you should also remove the stored settings from the Oomph settings file as well. HTH
OK. I tested with the last successeful build and it works as expected. However I still got the wrong behavior in my runtime environement (I test the behavior in a second eclipse instance, the first one contains the master plugins (last version of code)) I will fix my workspace preferences as suggested by Young S. If it works in the RCP product, never mind if it still did not working in my runtime environement :) So, Sorry for the disarrangement
