Community
Participate
Working Groups
this is a spin off from Bug 492356 : the same problem is raised while editting Parameter in protocol message: i,e in some case (type of port defined in systemelements profile) the newly editted port item in the project explorer got red cross decorator due to validation a possible solution is to use a simplified direct editor (only for name edit) similar to the simplication that has been done for transition Bug 476365
This looks like a duplicate of Bug 512809. I guess it is sufficient with the one that already have written. Either mark this one as a duplicate of Bug 512809, or make this one block Bug 512809 (since that one covers both ports and capsule parts).
Sorry, I did not see Bug 512809. you said in Bug 492356 Comment 9 that port port, you would like to have a fix for 0.9.0. could you then change the target milestone to 0.9.0 cause I nearly have the fix : I added the papyrus rt specific direct editor (simple editor modify only the name) what I still have to do is to ensure that it is the default one (for the moment, the xtext advanced editor is the default) I will check with Remi because he already define a specific editor for transition
(In reply to smaoui asma from comment #2) > Sorry, I did not see Bug 512809. you said in Bug 492356 Comment 9 that port > port, you would like to have a fix for 0.9.0. > could you then change the target milestone to 0.9.0 cause I nearly have the > fix : I added the papyrus rt specific direct editor (simple editor modify > only the name) what I still have to do is to ensure that it is the default > one (for the moment, the xtext advanced editor is the default) I will check > with Remi because he already define a specific editor for transition Keep in mind that I don't make the final call when it comes to planning. So even if I propose something, or have an opinion, it is Simon and Charles that makes the final call. You need to check with them first regarding what goes into which release. Bug 512809 is currently planned for 1.0. And yes, I did not expect it to be much work to get the same simple name based editor used for transitions, to also be used for port (and capsule parts). So it sounds good that you already have something in place. But I suggest that you talk with Simon first just to make sure he agrees with his.
Since this one is planned for 0.9, what is the progress of getting a fix for it in place? Ernesto wrote a duplicate Bug 513500 so I guess there is a huge chance that more 0.9 users will bump into this issue. Asma, you indicated earlier in Comment 2 that you already had started and nearly have a fix. What is status of that fix?
New Gerrit change created: https://git.eclipse.org/r/92954
I proposed here a fix, but this bug should be fixed in Papyrus instead see Bug 513583 I only proposed a workarround for 0.9.0 but the fix should be in Papyrus itself for the next release. I will confirm this with Papyrus team, but we can merge this fix for 0.9.0 and remove it when Papyrus bug got fixed. P.S : it worked with Transition accidentally because there were not a priority set to the xtext embedded editor see Bug 513583 for more details. Asma
(In reply to smaoui asma from comment #6) > I proposed here a fix, but this bug should be fixed in Papyrus instead see > Bug 513583 > > I only proposed a workarround for 0.9.0 but the fix should be in Papyrus > itself for the next release. > > I will confirm this with Papyrus team, but we can merge this fix for 0.9.0 > and remove it when Papyrus bug got fixed. > > P.S : it worked with Transition accidentally because there were not a > priority set to the xtext embedded editor see Bug 513583 for more details. > Asma Okay, so the Gerrit change https://git.eclipse.org/r/92954 is a proposed work-around for Papyrus-RT for the core issue in base Papyrus as tracked by Bug 513583? I would suggest to write a new Papyrus-RT bug for the tracking of reversal of work-around in Papyrus-RT, and let that bug depend on Bug 513583. This bug should then not depend on anything, so that we can close this for 0.9 when the proposed work-around in that Gerrit change have been merged. This is very similar to how was done with Bug 507449 tracking the work-around in Papyrus-RT, not depending on anything, and already closed, Bug 513361 tracking the reversal of that work-around, marked as depend_on_papyrus with a depends on dependency on the base Papyrus Bug 513267.
(setting Asma as assigned, as she is providing patches for it)
(In reply to Peter Cigehn from comment #7) > (In reply to smaoui asma from comment #6) > > I proposed here a fix, but this bug should be fixed in Papyrus instead see > > Bug 513583 > > > > I only proposed a workarround for 0.9.0 but the fix should be in Papyrus > > itself for the next release. > > > > I will confirm this with Papyrus team, but we can merge this fix for 0.9.0 > > and remove it when Papyrus bug got fixed. > > > > P.S : it worked with Transition accidentally because there were not a > > priority set to the xtext embedded editor see Bug 513583 for more details. > > Asma > > Okay, so the Gerrit change https://git.eclipse.org/r/92954 is a proposed > work-around for Papyrus-RT for the core issue in base Papyrus as tracked by > Bug 513583? I would suggest to write a new Papyrus-RT bug for the tracking > of reversal of work-around in Papyrus-RT, and let that bug depend on Bug > 513583. This bug should then not depend on anything, so that we can close > this for 0.9 when the proposed work-around in that Gerrit change have been > merged. > > This is very similar to how was done with Bug 507449 tracking the > work-around in Papyrus-RT, not depending on anything, and already closed, > Bug 513361 tracking the reversal of that work-around, marked as > depend_on_papyrus with a depends on dependency on the base Papyrus Bug > 513267. Thank you Peter for the suggestion, may be Bug 502269 is the Papyrus Bug that should blocks the Papyrus RT bug (to be written if the workarround is merged). Again, to merge the workarround, I need the validation of another committer such as Remi or a Papyrus committer.
Gerrit change https://git.eclipse.org/r/92954 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=01e3b27d5f3cc1204f2a6f95cee209afb4ef2796
(In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/92954 was merged to [master]. > Commit: > http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/ > ?id=01e3b27d5f3cc1204f2a6f95cee209afb4ef2796 Workaround has been merged. I removed this bug from being dependent of the bug 513583, and I close it for 0.9. I will then create a bug to revert that workaround, depending on the Papyrus bug 513583.
Verified to be fixed in the latest Papyrus-RT build. The direct editor for a port is now a simple name based editor, and the issues seen with ports typed by system protocol from the run-time model library do not appear anymore.
Closing as verified fixed.
