Bug 510974 - [HiDPI][GTK] ToolBar size too small at GDK_DPI_SCALE=3
Summary: [HiDPI][GTK] ToolBar size too small at GDK_DPI_SCALE=3
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 512821
Blocks:
  Show dependency tree
 
Reported: 2017-01-24 11:38 EST by Markus Keller CLA
Modified: 2018-11-09 10:22 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2017-01-24 11:38:35 EST
master including fix for bug 510772 on Ubuntu 16.04 (gtk 3.18.9)

- Set environment variable GDK_DPI_SCALE=3 and start the ControlExample.
- Switch to ToolBar tab.
=> The last image button is not shown, even if you make the window wide enough that it could be shown.

- Check SWT.WRAP.
=> overflow arrow appears for Image ToolBar (good)

- Check 50x50. => 
=> overflow image disappears again (should stay).

Doesn't seem to be a problem at 100% and 200%.

Originally seen in the Eclipse SDK, where some view toolbars (e.g. Package Explorer) don't get enough space to show all view buttons in the button bar.
Comment 1 Markus Keller CLA 2017-03-01 09:04:20 EST
To test this on a normal screen, you can use xrandr to find your normal output device (in my case: "VGA1 connected primary 1920x1200+0+0"), and then use something like this to simulate a HiDPI monitor:

$ xrandr --output VGA1 --scale 2x2 --panning 3840x2400

To go back to normal, use e.g.:

$ xrandr --output VGA1 --scale 1x1 --panning 0x0
Comment 2 Markus Keller CLA 2017-03-01 09:29:33 EST
Also happens for GDK_DPI_SCALE=5, but not for 4 or 2.5.
3.25 and 3.5 yield mixed results in ControlExample > ToolBar.
Comment 3 Eric Williams CLA 2018-05-16 15:40:57 EDT
Sravan, has this been fixed by the latest HiDPI work?
Comment 4 Sravan Kumar Lakkimsetti CLA 2018-05-17 05:32:03 EDT
(In reply to Eric Williams from comment #3)
> Sravan, has this been fixed by the latest HiDPI work?

Should be fixed. Need to verify once. I dont have a machine where I can go 300% scaling
Comment 5 Eric Williams CLA 2018-06-13 10:33:48 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #4)
> (In reply to Eric Williams from comment #3)
> > Sravan, has this been fixed by the latest HiDPI work?
> 
> Should be fixed. Need to verify once. I dont have a machine where I can go
> 300% scaling

I believe you can simulate 300% scaling by running the SWT snippet with the GDK_SCALE environment variable, with value 3.
Comment 6 Eric Williams CLA 2018-10-19 14:25:24 EDT
Ping, any update here?
Comment 7 Eric Williams CLA 2018-11-09 10:22:13 EST
(In reply to Eric Williams from comment #6)
> Ping, any update here?

Closing as there hasn't been a response in awhile -- please reopen if the issue still persists in 4.10.