510354 – Default TitleAreaDialog image looks bad on dark background

Bug 510354 - Default TitleAreaDialog image looks bad on dark background

Summary: Default TitleAreaDialog image looks bad on dark background

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.7 M5
Assignee:	Matthias Becker
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	511366
	Show dependency tree

Reported:	2017-01-12 08:00 EST by Lars Vogel
Modified:	2017-01-31 06:46 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2017-01-12 08:00:24 EST

I suggest we use a default icon which looks good on the light theme and the dark them. Maybe only adding a alpha value for the background is enough?

Comment 1 Lars Vogel

2017-01-12 08:01:58 EST

Matthias, something for you?

Comment 2 Matthias Becker

2017-01-16 07:25:10 EST

Hi Lars, 

with this little information it's hard to do anything on this bug.
What is the "Default TitleAreaDial image"? Can you provide a screenshot showing the issue? Can you tell me where the image is located?

Comment 3 Lars Vogel

2017-01-17 11:43:27 EST

The image is the following:

git/eclipse.platform.ui/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/images/title_banner.png

Example code to create a related dialog:

------

import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.dialogs.TitleAreaDialog;
import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Point;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Shell;

public class MyTitleAreaDialog extends TitleAreaDialog {

	/**
	 * Create the dialog.
	 * @param parentShell
	 */
	public MyTitleAreaDialog(Shell parentShell) {
		super(parentShell);
	}

	/**
	 * Create contents of the dialog.
	 * @param parent
	 */
	@Override
	protected Control createDialogArea(Composite parent) {
		Composite area = (Composite) super.createDialogArea(parent);
		Composite container = new Composite(area, SWT.NONE);
		container.setLayoutData(new GridData(GridData.FILL_BOTH));

		return area;
	}

}

---------

Comment 4 Eclipse Genie

2017-01-18 10:28:23 EST

New Gerrit change created: https://git.eclipse.org/r/88992

Comment 5 Eclipse Genie

2017-01-18 10:32:02 EST

New Gerrit change created: https://git.eclipse.org/r/88993

Comment 6 Matthias Becker

2017-01-18 10:33:45 EST

I already had this as the background in new_wiz.svg/png in the wizban folder of the org.eclipse.ui.ide plugin. So I simply copied this over.

Comment 7 Eclipse Genie

2017-01-18 14:55:10 EST

Gerrit change https://git.eclipse.org/r/88992 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=cc67be01db7b81c46b86dbf010727a0769619b28

Comment 8 Eclipse Genie

2017-01-18 14:55:35 EST

Gerrit change https://git.eclipse.org/r/88993 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a652c335f0731329d0de475ca7e640cb275ff851

Comment 9 Lars Vogel

2017-01-18 15:01:51 EST

Thanks Matthias.