509644 – Fragments with index merged in wrong order

Bug 509644 - Fragments with index merged in wrong order

Summary: Fragments with index merged in wrong order

Status:	CLOSED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.8 M2
Assignee:	Alexandra Buzila
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-12-22 09:01 EST by Alexandra Buzila
Modified:	2020-04-26 13:15 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit 562472 562497

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexandra Buzila

2016-12-22 09:01:08 EST

Fragment contributions are not merged in their correct position in the parent list, when the contributions contain multiple nesting levels.

For example, if all the children of Menu 0 are contributed each in a separate fragment and out of order, with the given indices, the final order is incorrect.

  Menu 0
    Menu 0.0 index:1
        MenuItem 0.0.0 index:0
        MenuItem 0.0.1 index:10
    Menu 0.1 index:10
    Menu 0.2 index:20

Comment 1 Eclipse Genie

2016-12-22 09:08:35 EST

New Gerrit change created: https://git.eclipse.org/r/87634

Comment 2 Eclipse Genie

2017-08-07 05:37:11 EDT

Gerrit change https://git.eclipse.org/r/87634 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b3f875c20a46971abeb23067c5cfe701d4750b23

Comment 3 Thomas Schindl

2017-09-29 12:08:17 EDT

This is merged but the ticket is not marked as resolved why?

Comment 4 Lars Vogel

2017-09-29 12:12:06 EDT

(In reply to Thomas Schindl from comment #3)
> This is merged but the ticket is not marked as resolved why?

Committer forgot to set status?

Comment 5 Alexandra Buzila

2017-10-04 05:25:51 EDT

Verified in I20170913-2000