Community
Participate
Working Groups
Created attachment 265531 [details] Screenshot on Windows 10 Please run the attached sample. Though a light-gray foreground color has been set, it still shows the default black text color.
Created attachment 265532 [details] Snippet
See also bug 509220 covering the the selection color of toggle toolbar buttons.
I provided a gerrit patch, that can be reviewed. This patch needs a rebuild of the SWT binaries!
@Niraj: Can you please have a look at the patch? Although it needs a rebuild of the binaries, the change itself is very small. And it is a further step towards a good dark theme on Windows.
(In reply to Conrad Groth from comment #4) > @Niraj: Can you please have a look at the patch? Although it needs a rebuild > of the binaries, the change itself is very small. And it is a further step > towards a good dark theme on Windows. Tentative for 4.7, since CustomDrawing patches need lot of validation/testing, suggest we plan this in next release.
Created attachment 271348 [details] ToolBar_DarkTheme_DropDown_Issue (In reply to Conrad Groth from comment #3) > I provided a gerrit patch, that can be reviewed. This patch needs a rebuild > of the SWT binaries! Hi Conrad, The patch work clean on Windows 64bit and 32bit both. Largely the behavior look fine to me. Found one issue with the ToolBar's DropDown arrow which continues to be in black color irrespective on the foreground/background color. IMO, if possible this DropDown triangle should be of the same color as Toolbar foreground. Please refer attached screen-grab, created using ControlExample.java
(In reply to Niraj Modi from comment #6) > Created attachment 271348 [details] > ToolBar_DarkTheme_DropDown_Issue > ... > Found one issue with the ToolBar's DropDown arrow which continues to be in > black color irrespective on the foreground/background color. IMO, if > possible this DropDown triangle should be of the same color as Toolbar > foreground. > Please refer attached screen-grab, created using ControlExample.java I agree with you. Unfortunately there's no API method for changing that arrow's Color, so that would be more work of custom drawing. As this bug was 'only' about the text Color I would like to move that topic to another ticket.
Hi Conrad, Targeting for M4 as the latest patch looks good and now works for both 64bit & 32bit setups. Only verified the specified use-case, will test further to confirm if there are no side effects/breakages. Note: I will be on vacation next week, hence will get back to you after that. (In reply to Conrad Groth from comment #7) > (In reply to Niraj Modi from comment #6) > I agree with you. Unfortunately there's no API method for changing that > arrow's Color, so that would be more work of custom drawing. As this bug was > 'only' about the text Color I would like to move that topic to another > ticket. Ok, please raise a separate bug for this. Thanks!
Largely patch is good, will do more elaborate testing with Eclipse(self-hosted mode)possible candidate for early M5. Thanks!
(In reply to Niraj Modi from comment #8) ... > (In reply to Conrad Groth from comment #7) > > (In reply to Niraj Modi from comment #6) > > I agree with you. Unfortunately there's no API method for changing that > > arrow's Color, so that would be more work of custom drawing. As this bug was > > 'only' about the text Color I would like to move that topic to another > > ticket. > Ok, please raise a separate bug for this. Thanks! see bug 528406
(In reply to Niraj Modi from comment #9) > Largely patch is good, will do more elaborate testing with > Eclipse(self-hosted mode)possible candidate for early M5. Thanks! Tested the latest patch on Win7 both 64bit and 32bit looks good. Pushed the changes to master via Gerrit, corresponding git commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=aa02710cfd49bf59fc4fcded6a2bbdb9cdfba8bb
Thanks Conrad for your work on this issue, resolving now.
Verified fix in Build id: I20180122-2000 on Win7/Win10.
I still see the issue with the Toolbar Dropdown in Dark Theme in build 20180315-1217
